Caption as link content for inline broken media
Closed, ResolvedPublic
Actions

Description

For an example, [[File:Test123123.jpg|Testing 123]]

Legacy output,

<p><a href="/index.php?title=Special:Upload&amp;wpDestFile=Test123123.jpg" class="new" title="File:Test123123.jpg">Testing 123</a>

Parsoid output,

<p><span class="mw-default-size" typeof="mw:Error mw:Image" data-mw='{"caption":"Testing 123","errors":[{"key":"apierror-filedoesnotexist","message":"This image does not exist."}]}'><a href="./Special:FilePath/Test123123.jpg"><span resource="./File:Test123123.jpg">File:Test123123.jpg</span></a></span></p>

Details

Subject	Repo	Branch	Lines +/-
Bump parsoid to 0.17.0-a18	mediawiki/vendor	master	+648 -273
Use alt as link content for broken media	mediawiki/services/parsoid	master	+82 -114
Preserve link content for broken media	mediawiki/extensions/VisualEditor	master	+55 -22
Use alt as link content for broken media	mediawiki/core	master	+130 -17

Customize query in gerrit

Related Objects

Mentioned In: T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc.
Mentioned Here: T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc.

Event Timeline

Arlolra created this task.Jan 26 2021, 10:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2021, 10:37 PM

In T266149#6758710, @cscott wrote:
WRT captions appearing in the error case:
The {MediaWiki DOM Spec](https://www.mediawiki.org/wiki/Specs/HTML/2.2.0#Images) says:
<figcaption (absent when inline)>...</figcaption>
and

The outer <figure> element needs to become a <span> element when the figure is rendered inline, since otherwise the HTML5 parser will interrupt a surrounding block context. The inner <figcaption> element is rendered as a data-mw attribute in this case (since block content in an invisible caption would otherwise break parsing).

So the issue here is a bit of ambiguity in what "when rendered inline" means, and we can be more precise about it. But probably "rendered inline" meaning "uses a span as the wrapper" and so if we decide to output the caption for broken error cases we should also change the outer wrapper from "span" to "figure". That might also cause rendering differences, but at least it would be self-consistent. Then we'd just need to clarify that media will be "rendered inline" only for non-error cases.

Arlolra mentioned this in T266149: Run another round of visual diff testing after tweaking core patches that change media output to <figure>, etc..Jan 26 2021, 10:38 PM

Change 658699 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/core@master] [WIP] Caption as link content for inline broken media

https://gerrit.wikimedia.org/r/658699

gerritbot added a project: Patch-For-Review.Jan 26 2021, 11:19 PM

Arlolra edited projects, added Parsoid-Media-Structure; removed Parsoid.Jul 13 2021, 5:14 PM

MBinder_WMF added a project: Parsoid-Read-Views-Deprecated-Project (Phase 0 - Parsoid-Media-Structure).Sep 3 2021, 9:30 PM

MBinder_WMF edited projects, added Parsoid; removed Parsoid-Read-Views-Deprecated-Project (Phase 0 - Parsoid-Media-Structure).Sep 3 2021, 9:37 PM

MBinder_WMF added a project: Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure).Sep 3 2021, 9:58 PM

Arlolra moved this task from Backlog to Needs decision on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Sep 16 2022, 1:00 AM

Change 887440 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Use alt as link content for broken media

https://gerrit.wikimedia.org/r/887440

Arlolra claimed this task.Feb 8 2023, 3:36 PM

Arlolra added a project: Content-Transform-Team-WIP.