Page MenuHomePhabricator
Create Task
Maniphest T273084

HomepageModule events with validation errors
Closed, ResolvedPublic
Actions

Description

https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-2021.01.27?id=erZ9RHcBoqQO90dBm7yq

'.event.state' should be equal to one of the allowed values

"state":"enabled"

"enabled" is not a valid value in the state field enum:
https://schema.wikimedia.org/repositories//secondary/jsonschema/analytics/legacy/homepagemodule/1.1.0.yaml

https://logstash.wikimedia.org/goto/431fbc5cf2de97f1260156c78e78d788

Details

SubjectRepoBranchLines +/-
Banner module: Switch to using activated/unactivated for statemediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.27+1 -1
Banner module: Switch to using activated/unactivated for statemediawiki/extensions/GrowthExperimentsmaster+1 -1
Banner module: Switch to using activated/unactivated for statemediawiki/extensions/GrowthExperimentswmf/1.36.0-wmf.28+1 -1
homepagemodule: Add missing "enabled" stateschemas/event/secondarymaster+719 -4
GrowthExperiments: Bump schema version for homepagemoduleoperations/mediawiki-configmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Ottomata created this task.Jan 27 2021, 5:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2021, 5:12 PM
Aklapper added a project: GrowthExperiments-Homepage.Jan 28 2021, 11:25 AM
kostajh edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jan 29 2021, 10:22 AM
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Ottomata mentioned this in T270309: Instrument banner module on newcomer homepage.Feb 1 2021, 2:24 PM
kostajh claimed this task.Feb 1 2021, 6:18 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Feb 1 2021, 6:40 PM

Change 660872 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[schemas/event/secondary@master] homepagemodule: Add missing "enabled" state

https://gerrit.wikimedia.org/r/660872

gerritbot added a project: Patch-For-Review.Feb 1 2021, 6:40 PM
gerritbot added a comment.Feb 1 2021, 6:44 PM

Change 660874 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[operations/mediawiki-config@master] GrowthExperiments: Bump schema version for homepagemodule

https://gerrit.wikimedia.org/r/660874

gerritbot added a comment.Feb 1 2021, 7:05 PM

Change 660907 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Banner module: Switch to using activate/unactivated for state

https://gerrit.wikimedia.org/r/660907

gerritbot added a comment.Feb 1 2021, 7:06 PM

Change 660874 abandoned by Kosta Harlan:
[operations/mediawiki-config@master] GrowthExperiments: Bump schema version for homepagemodule

Reason:
See Ia66be5fb6853a6d169c1fe41380d7b42cb5acdbc

https://gerrit.wikimedia.org/r/660874

gerritbot added a comment.Feb 1 2021, 7:07 PM

Change 660872 abandoned by Kosta Harlan:
[schemas/event/secondary@master] homepagemodule: Add missing "enabled" state

Reason:
See Ia66be5fb6853a6d169c1fe41380d7b42cb5acdbc

https://gerrit.wikimedia.org/r/660872

gerritbot added a comment.Feb 1 2021, 7:15 PM

Change 660926 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.28] Banner module: Switch to using activated/unactivated for state

https://gerrit.wikimedia.org/r/660926

gerritbot added a comment.Feb 1 2021, 7:34 PM

Change 660926 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.28] Banner module: Switch to using activated/unactivated for state

https://gerrit.wikimedia.org/r/660926

Stashbot added a comment.Feb 1 2021, 7:39 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-01T19:38:59Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.28/extensions/GrowthExperiments/includes/HomepageModules/Banner.php: d39746aa3ed07dfa9173a98d253c61771d5592a1: Banner module: Switch to using activated/unactivated for state (T273084) (duration: 01m 05s)

gerritbot added a comment.Feb 1 2021, 7:43 PM

Change 660907 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Banner module: Switch to using activated/unactivated for state

https://gerrit.wikimedia.org/r/660907

kostajh moved this task from In Progress to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 1 2021, 7:44 PM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Feb 1 2021, 8:00 PM
gerritbot added a comment.Feb 2 2021, 11:55 AM

Change 661086 had a related patch set uploaded (by Urbanecm; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.27] Banner module: Switch to using activated/unactivated for state

https://gerrit.wikimedia.org/r/661086

gerritbot added a comment.Feb 2 2021, 12:15 PM

Change 661086 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.36.0-wmf.27] Banner module: Switch to using activated/unactivated for state

https://gerrit.wikimedia.org/r/661086

Stashbot added a comment.Feb 2 2021, 12:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-02-02T12:20:38Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.27/extensions/GrowthExperiments/includes/HomepageModules/Banner.php: da8f328640ca5c46385a57e706cd76614bbfdc7a: Banner module: Switch to using activated/unactivated for state (T273084) (duration: 00m 58s)

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.27; 2021-01-19); removed MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Feb 2 2021, 2:00 PM
Etonkovidova mentioned this in T273700: eventgate_validation_error for NewcomerTask, HomepageTask, and HomepageVisit schemas.Feb 3 2021, 1:31 AM
Etonkovidova subscribed.Feb 16 2021, 10:55 PM

Checked in wmf.30 (along with T273700) - the errors are not present.

Etonkovidova closed this task as Resolved.Feb 16 2021, 10:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits