Page MenuHomePhabricator

Argument 1 passed to CentralAuthUser::getInstance() must be an instance of User, boolean given
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error message
TypeError: Argument 1 passed to CentralAuthUser::getInstance() must be an instance of User, boolean given, called in /srv/mediawiki/php-1.36.0-wmf.27/extensions/CentralAuth/includes/CentralAuthCreateLocalAccountJob.php on line 42

There have been 76 errors like this in the last hour.

Details

Request ID
YBLltwpAADkAADRzVXUAAAEL
Request URL
jobrunner.discovery.wmnet/rpc/RunSingleJob.php
Stack Trace
Stack Trace
from /srv/mediawiki/php-1.36.0-wmf.27/extensions/CentralAuth/includes/CentralAuthUser.php(168)
#0 /srv/mediawiki/php-1.36.0-wmf.27/extensions/CentralAuth/includes/CentralAuthCreateLocalAccountJob.php(42): CentralAuthUser::getInstance(boolean)
#1 /srv/mediawiki/php-1.36.0-wmf.27/extensions/EventBus/includes/JobExecutor.php(79): CentralAuthCreateLocalAccountJob->run()
#2 /srv/mediawiki/rpc/RunSingleJob.php(76): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#3 {main}

Event Timeline

hmmm, that stack trace is from php-1.36.0-wmf.27 but the patch mentioned above is only included in wmf.28 and CentralAuthCreateLocalAccountJob.php(42) is an empty line in both branches

280 instances over the last 4 hours. Unknown user-facing impact.

Change 659362 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/CentralAuth@master] Revert CentralAuthCreateLocalAccountJob changes in 9f79de4

https://gerrit.wikimedia.org/r/659362

Turns out I misread and 42 was only empty in .28, not in .27. The above patch should fix these. I believe this is caused by changes in the job constructor since the job might be run on a different wiki than it was sent to the queue from. The change was only removing unused parameters so reverting it is fine.

Majavah triaged this task as Unbreak Now! priority.

UBN as train blocker

Change 659278 had a related patch set uploaded (by Brennen Bearnes; owner: Majavah):
[mediawiki/extensions/CentralAuth@wmf/1.36.0-wmf.28] Revert CentralAuthCreateLocalAccountJob changes in 9f79de4

https://gerrit.wikimedia.org/r/659278

Change 659278 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@wmf/1.36.0-wmf.28] Revert CentralAuthCreateLocalAccountJob changes in 9f79de4

https://gerrit.wikimedia.org/r/659278

Change 659362 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Revert CentralAuthCreateLocalAccountJob changes in 9f79de4

https://gerrit.wikimedia.org/r/659362

Mentioned in SAL (#wikimedia-operations) [2021-01-28T21:11:20Z] <brennen@deploy1001> Synchronized php-1.36.0-wmf.28/extensions/CentralAuth/includes/: Backport: [[gerrit:659362|Revert CentralAuthCreateLocalAccountJob changes in 9f79de4 (T273205)]] (duration: 01m 09s)

Majavah raised the priority of this task from High to Unbreak Now!.
Majavah updated the task description. (Show Details)
Majavah edited Stack Trace. (Show Details)
Majavah added subscribers: RhinosF1, Majavah, dancy, Aklapper.