Argument 1 passed to CentralAuthUser::getInstance() must be an instance of User, boolean given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	dancy
	Jan 28 2021, 4:55 PM

Description

Error message

TypeError: Argument 1 passed to CentralAuthUser::getInstance() must be an instance of User, boolean given, called in /srv/mediawiki/php-1.36.0-wmf.27/extensions/CentralAuth/includes/CentralAuthCreateLocalAccountJob.php on line 42

There have been 76 errors like this in the last hour.

Details

Request ID: YBLltwpAADkAADRzVXUAAAEL
Request URL: jobrunner.discovery.wmnet/rpc/RunSingleJob.php

Stack Trace

from /srv/mediawiki/php-1.36.0-wmf.27/extensions/CentralAuth/includes/CentralAuthUser.php(168)
#0 /srv/mediawiki/php-1.36.0-wmf.27/extensions/CentralAuth/includes/CentralAuthCreateLocalAccountJob.php(42): CentralAuthUser::getInstance(boolean)
#1 /srv/mediawiki/php-1.36.0-wmf.27/extensions/EventBus/includes/JobExecutor.php(79): CentralAuthCreateLocalAccountJob->run()
#2 /srv/mediawiki/rpc/RunSingleJob.php(76): MediaWiki\Extension\EventBus\JobExecutor->execute(array)
#3 {main}

	Subject	Repo	Branch	Lines +/-
	Revert CentralAuthCreateLocalAccountJob changes in 9f79de4	mediawiki/extensions/CentralAuth	master	+12 -2
	Revert CentralAuthCreateLocalAccountJob changes in 9f79de4	mediawiki/extensions/CentralAuth	wmf/1.36.0-wmf.28	+12 -2

Customize query in gerrit

Related Objects

Mentioned Here: rECAU9f79de43eb1e: Add injectable CentralAuthUtilityService to replace CentralAuthUtils

Event Timeline

dancy created this task.Jan 28 2021, 4:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2021, 4:55 PM

This sounds like it might be related to my patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/651945, I'm taking a look

hmmm, that stack trace is from php-1.36.0-wmf.27 but the patch mentioned above is only included in wmf.28 and CentralAuthCreateLocalAccountJob.php(42) is an empty line in both branches

280 instances over the last 4 hours. Unknown user-facing impact.

Change 659362 had a related patch set uploaded (by Majavah; owner: Majavah):
[mediawiki/extensions/CentralAuth@master] Revert CentralAuthCreateLocalAccountJob changes in 9f79de4

https://gerrit.wikimedia.org/r/659362

gerritbot added a project: Patch-For-Review.Jan 28 2021, 6:23 PM

Turns out I misread and 42 was only empty in .28, not in .27. The above patch should fix these. I believe this is caused by changes in the job constructor since the job might be run on a different wiki than it was sent to the queue from. The change was only removing unused parameters so reverting it is fine.

UBN as train blocker

Restricted Application added a project: User-Majavah. · View Herald TranscriptJan 28 2021, 7:01 PM

RhinosF1 subscribed.Jan 28 2021, 7:02 PM

Change 659278 had a related patch set uploaded (by Brennen Bearnes; owner: Majavah):
[mediawiki/extensions/CentralAuth@wmf/1.36.0-wmf.28] Revert CentralAuthCreateLocalAccountJob changes in 9f79de4

https://gerrit.wikimedia.org/r/659278

Change 659278 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@wmf/1.36.0-wmf.28] Revert CentralAuthCreateLocalAccountJob changes in 9f79de4

https://gerrit.wikimedia.org/r/659278

Change 659362 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Revert CentralAuthCreateLocalAccountJob changes in 9f79de4

https://gerrit.wikimedia.org/r/659362

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.29; 2021-02-02).Jan 28 2021, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 28 2021, 9:10 PM

Mentioned in SAL (#wikimedia-operations) [2021-01-28T21:11:20Z] <brennen@deploy1001> Synchronized php-1.36.0-wmf.28/extensions/CentralAuth/includes/: Backport: [[gerrit:659362|Revert CentralAuthCreateLocalAccountJob changes in 9f79de4 (T273205)]] (duration: 01m 09s)