There have been more dirty diffs recently that look like T268407. I think they're caused by different issues though (not a regression).
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix replying outside wrappers for partially indented comments | mediawiki/extensions/DiscussionTools | master | +71 -35 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 662773 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix replying outside wrappers for partially indented comments
Comment Actions
That patch only fixes case 4. When I was filing this, I was hoping they would all be fixed at once in some easy way, but alas…
Quick notes about the rest:
- 1: there's an empty mw:Transclusion node, getFullyCoveredSiblings() should ignore nodes that match isRenderingTransparentNode()
- 2: there's a <p class="mw-empty-elt">, it should be ignored somewhere in the code, not sure
- 3: the comment is not fully covered by wrappers because of funky indentation, no good ideas on how to fix it at the moment
- 4: the comment was treated as partially indented because it ends with a list, which we didn't handle right
Comment Actions
Change 662773 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix replying outside wrappers for partially indented comments
Comment Actions
Case 1 and 2 look fixed. Case 3 isn't, and I don't think it's worth further work.
I'll close this as invalid since it was a pretty bad bug report about 4 different issues.