Page MenuHomePhabricator

Reply inserted before closing wrapper tags at end of line (round 2)
Open, Needs TriagePublic

Description

There have been more dirty diffs recently that look like T268407. I think they're caused by different issues though (not a regression).

Event Timeline

Change 662773 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Fix replying outside wrappers for partially indented comments

https://gerrit.wikimedia.org/r/662773

That patch only fixes case 4. When I was filing this, I was hoping they would all be fixed at once in some easy way, but alas…

Quick notes about the rest:

  • 1: there's an empty mw:Transclusion node, getFullyCoveredSiblings() should ignore nodes that match isRenderingTransparentNode()
  • 2: there's a <p class="mw-empty-elt">, it should be ignored somewhere in the code, not sure
  • 3: the comment is not fully covered by wrappers because of funky indentation, no good ideas on how to fix it at the moment
  • 4: the comment was treated as partially indented because it ends with a list, which we didn't handle right

Change 662773 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Fix replying outside wrappers for partially indented comments

https://gerrit.wikimedia.org/r/662773

ppelberg added a subscriber: ppelberg.

@ppelberg to review the issue and then triage accordingly.

This may have been improved by the changes from T297034, but I can't test easily now due to T314260. I'll check it when that patch is live.