Reply links no longer showing on old revisions
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Esanders
	Jul 31 2022, 9:42 PM

Description

This stopped after https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/802212, which was a patch targeting previews.

As the reply widget does a good job of handling conflicts and pre-warning if there are new comments in the sections, this may not be necessary, and should at least be done intentionally.

Details

	Subject	Repo	Branch	Lines +/-
	Bring back [reply] links in old revisions without breaking preview	mediawiki/extensions/DiscussionTools	master	+5 -20

Customize query in gerrit

Related Objects

Mentioned In: T321985: Wikilove and DiscussionTools do not get along
T315334: subscribe button not visible when signature is below sub-header
T273692: Reply inserted before closing wrapper tags at end of line (round 2)
T314623: DiscussionTools appends emptystate banner on `action=parse`

Event Timeline

• Esanders created this task.Jul 31 2022, 9:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 31 2022, 9:42 PM

Oh no… I'll think about another way to do this.

Change 819725 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Bring back [reply] links in old revisions without breaking preview

https://gerrit.wikimedia.org/r/819725

gerritbot added a project: Patch-For-Review.Aug 2 2022, 7:57 PM

matmarex added a project: Editing-team (Kanban Board).Aug 2 2022, 7:58 PM

matmarex moved this task from Backlog to Triaged on the DiscussionTools board.

matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Change 819725 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Bring back [reply] links in old revisions without breaking preview

https://gerrit.wikimedia.org/r/819725

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.25; 2022-08-15).Aug 2 2022, 9:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2022, 9:31 PM

• Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Aug 3 2022, 12:16 AM

• Esanders added a project: Editing QA.

• Esanders moved this task from Inbox to Low Priority on the Editing QA board.

matmarex mentioned this in T314623: DiscussionTools appends emptystate banner on `action=parse`.Aug 5 2022, 4:17 PM

matmarex mentioned this in T273692: Reply inserted before closing wrapper tags at end of line (round 2).Aug 5 2022, 11:28 PM

Ryasmeen edited projects, added Verified; removed Editing QA.Aug 15 2022, 12:46 PM

matmarex moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Aug 16 2022, 3:34 PM

matmarex mentioned this in T315334: subscribe button not visible when signature is below sub-header.Aug 17 2022, 3:55 PM

ppelberg closed this task as Resolved.Aug 18 2022, 12:39 AM

matmarex mentioned this in T321985: Wikilove and DiscussionTools do not get along.Oct 30 2022, 9:01 PM

Reply links no longer showing on old revisionsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Reply links no longer showing on old revisions
Closed, ResolvedPublic
Actions