Page MenuHomePhabricator

Fix typo in description of train deployments tasks
Closed, ResolvedPublic

Description

In the description text for train deployments, like T271344, there is

Any open subtask(s) block the train from moving forward.This means no further deployments until the blockers are resolved.

there is a space missing between "forward." and "This". However, when I try to edit the task (eg https://phabricator.wikimedia.org/maniphest/task/edit/271344/) the description field is empty, which I suspect means that the text being shown is kept somewhere else (part of a form?).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I figured out how to submit a patch (I think I did it right) - thanks for figuring out where it was coded

For future reference:
git clone https://phabricator.wikimedia.org/source/phab-extensions.git
create a branch, make the changes
git diff master
copy the result (minus the automatic removal of a newline in this case) and paste into https://phabricator.wikimedia.org/differential/diff/create/

@thcipriani has "accepted" the patch (D1189#24018) but was it merged? Looking at the example task I mentioned in the description (T271344) shows that the issue appears to have been resolved - was it fixed because the patch was merged, or because someone else fixed it?

DannyS712 assigned this task to thcipriani.
DannyS712 removed a project: Patch-For-Review.

It was fixed as part of d238db85b8d8

Thanks - I abandoned my patch