Page MenuHomePhabricator
Create Task
Maniphest T275563

Unify search icon to DSG standard one on mobile
Closed, ResolvedPublic
Actions

Description

With the updates to 'search' icon we should also clean up the inconsistency on mobile.

CurrentProposed
image.png (108×1 px, 12 KB)
image.png (108×1 px, 12 KB)

Details

SubjectRepoBranchLines +/-
icons: Update to latest 'search' icon and remove obsolete codemediawiki/skins/MinervaNeuemaster+6 -13
Update search header to rely on standard background 'search' iconmediawiki/extensions/MobileFrontendmaster+3 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Feb 23 2021, 9:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2021, 9:44 PM
Volker_E updated the task description. (Show Details)Feb 23 2021, 10:41 PM
gerritbot added a comment.Feb 23 2021, 10:46 PM

Change 666479 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Update search header to rely on standard background 'search' icon

https://gerrit.wikimedia.org/r/666479

gerritbot added a project: Patch-For-Review.Feb 23 2021, 10:46 PM
• alexhollender_WMF added a comment.Feb 23 2021, 11:00 PM

looks good to me 👏

gerritbot added a comment.Mar 3 2021, 12:23 AM

Change 666479 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Update search header to rely on standard background 'search' icon

https://gerrit.wikimedia.org/r/666479

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2021, 1:10 AM
Volker_E closed this task as Resolved.Mar 8 2021, 8:16 PM
Volker_E claimed this task.
Volker_E triaged this task as Medium priority.
gerritbot added a comment.Mar 9 2021, 8:21 AM

Change 666488 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] icons: Update to latest 'search' icon and remove obsolete code

https://gerrit.wikimedia.org/r/666488

gerritbot added a project: Patch-For-Review.Mar 9 2021, 8:21 AM
gerritbot added a comment.Mar 9 2021, 9:11 AM

Change 666488 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] icons: Update to latest 'search' icon and remove obsolete code

https://gerrit.wikimedia.org/r/666488

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 9 2021, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 9 2021, 10:10 AM
• alexhollender_WMF mentioned this in T279015: [Visual bug] search icon increases in size when Vue loads.Mar 31 2021, 9:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits