| • alexhollender_WMF | |
| Mar 31 2021, 9:05 PM |
| F34533452: search icon.webm | |
| Jun 30 2021, 7:14 PM |
| F34525817: search icon.webm | |
| Jun 24 2021, 5:26 PM |
| F34520395: search icon shift.webm | |
| Jun 22 2021, 4:28 PM |
| F34518370: image.png | |
| Jun 21 2021, 2:47 PM |
| F34518374: Kapture 2021-06-21 at 10.35.58.webm | |
| Jun 21 2021, 2:47 PM |
| F34488946: Screen Recording 2021-06-09 at 9.55.49 AM.mov.gif | |
| Jun 10 2021, 4:42 AM |
| F34199914: Screen Shot 2021-03-31 at 5.00.50 PM.png | |
| Mar 31 2021, 9:05 PM |
When you focus the input field for the first time and Vue loads, the search icon increases in size. To illustrate, the red box is the same size in both screenshots:
Potentially related to one of these recently closed tasks?
| AC | Status | Details |
|---|---|---|
| 1 | ❓ | T279015#7147623 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core | |||
| Open | None | T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core | |||
| Open | None | T85394 Use OOUI suggestions/autocompletion components only (instead of jquery.suggestions, jquery.ui.autocomplete) | |||
| Open | None | T125725 [epic] Update autocomplete search box with metadata and remove and delete the old searchSuggest system | |||
| Resolved | ovasileva | T244392 [GOAL] Deploy the new Vue.js search experience | |||
| Resolved | Volker_E | T249299 [Epic] Build the new Vue.js search experience | |||
| Resolved | Volker_E | T279015 [Visual bug] search icon increases in size when Vue loads |
Which is the right icon? before or after?
The before comes from this icon asset (common to legacy skin)
https://github.com/wikimedia/Vector/blob/master/resources/common/images/search.svg
The latter comes from wvui.
Depending on which is the correct one, we need to update the incorrect one.
Both icons are using 20x20 width/height so only the content of the SVG needs to be fixed here.
The task becomes a little more risky if we update Vector as we'll need to consider the legacy experience, and whether we want to change it there too.
@alexhollender The icon in WVUI didn't receive the update of Vector/MinervaNeue/OOUI yet! It's outdated.
Working on it.
Change 685251 had a related patch set uploaded (by VolkerE; author: VolkerE):
[wvui@master] [icons] Update outdated 'wvuiIconSearch' icon
Change 685251 merged by jenkins-bot:
[wvui@master] [icons] Update outdated 'wvuiIconSearch' search icon
Nope, on WVUI release. WVUI uses its own icons.
Bug will be updated as soon as release is cut.
@alexhollender This hasn't made the cut back for current WVUI v0.1.1. Will be in the next release of WVUI (this or max next week for deployment +1 week later).
Change 697700 had a related patch set uploaded (by Catrope; author: Catrope):
[mediawiki/core@master] Update wvui to 0.2.0
Status: ❓ need more info
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
❓ AC1: Search icon should not increase in size when the search field is focused.
@Jdlrobson It doesn't look like the icon is changing size, but it does move. I'm not failing this because I'm not sure if the movement is in the scope of this task in addition to the size.
I think this is a pass, but we should check with @alexhollender
@alexhollender please move to QA in prod if the above is correct. Needs more work if it needs more work.
@Jdlrobson @Volker_E the icon is now staying the same size, which was the goal of this task, however a new issue is occurring:
the shift in location between Initial state and Expanded state is expected and correct. The shift in location between Expanded state and Final state should not be happening. Not sure if the video is more helpful:
not sure if you want to keep working within this task or open a new one...
to further clarify what seems to be happening here:
Change 700954 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):
[mediawiki/skins/Vector@master] Fixes transition from input focus state to WVUI focus state
Change 700954 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Fixes transition from input focus state to WVUI focus state
Can you check this on https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page and move to QA column if satisfied?
Let's skip QA here, as there's another related task identified (that will need a WVUI release) – T286955: WVUI: Search icon not centered
Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted: