Page MenuHomePhabricator
Create Task
Maniphest T213580

Use consistent 'search' icon across products
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Volker_E
Authored By
Volker_E
Jan 11 2019, 9:26 PM
Tags
Referenced Files
F34120787: image.png
Feb 24 2021, 10:19 AM
F34120789: image.png
Feb 24 2021, 10:19 AM
F34120792: image.png
Feb 24 2021, 10:19 AM
F34120785: image.png
Feb 24 2021, 10:19 AM
Subscribers
Aklapper
Glaisher
Jdlrobson
Liuxinyu970226
Maryana
Masumrezarock100
• MZMcBride
View All 14 Subscribers

Description

With T177432 we've got a search icon that seeks implementation everywhere:
New search icon added to Design Style Guide, slightly smaller, 18x18dp on 20x20dp canvas

BeforeAfter
image.png (534×1 px, 49 KB)
image.png (552×1 px, 49 KB)
image.png (420×1 px, 48 KB)
image.png (414×1 px, 48 KB)

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.41.2mediawiki/coremaster+147 -162
Amend 'search' icon and fit into inputmediawiki/extensions/Translatemaster+12 -11
icons: Update to latest 'search' icon and remove obsolete codemediawiki/skins/MinervaNeuemaster+6 -13
[icons] Amend 'search' iconmediawiki/skins/Vectormaster+1 -1
icons: Amend 'search' size on canvas slightlyoojs/uimaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E triaged this task as Medium priority.Jan 11 2019, 9:26 PM
Volker_E created this task.
Volker_E updated the task description. (Show Details)Apr 25 2019, 5:26 PM
Volker_E added a project: Patch-For-Review.Apr 25 2019, 6:16 PM

jquery.uls is tackled in https://github.com/wikimedia/jquery.uls/pull/335

• Petar.petkovic subscribed.Apr 26 2019, 9:17 AM

ext.cx.tools.less & ext.cx.tools.linker.less are part of old Content Translation codebase (CX1), which is now out there only to support editing of old translations which are started with CX1. After T212646, it is no longer possible to start new translations using CX1.

We don't make changes in CX1 codebase, which will be removed eventually.

Volker_E updated the task description. (Show Details)Apr 26 2019, 9:34 AM
Volker_E updated the task description. (Show Details)
Volker_E mentioned this in T218451: MinervaNeue icons standardization.Apr 26 2019, 10:04 AM
Volker_E added a parent task: T218451: MinervaNeue icons standardization.
Volker_E updated the task description. (Show Details)May 3 2019, 5:08 PM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)Oct 9 2019, 10:09 PM
Volker_E removed a parent task: T218451: MinervaNeue icons standardization.
Volker_E added a subtask: T218451: MinervaNeue icons standardization.
Volker_E closed subtask T266166: Use standard icon on Vector search as Resolved.Dec 7 2020, 12:59 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptDec 7 2020, 12:59 PM
Volker_E moved this task from Unsorted to Icons standardization on the UI-Standardization board.Feb 23 2021, 8:31 PM
Volker_E added a comment.Feb 23 2021, 8:37 PM

As of today, initiated by Desktop Improvements project work, we have a minor amendment to the 'search' icon which needs to be rolled out once more to all users of it.

Volker_E updated the task description. (Show Details)Feb 23 2021, 8:39 PM
gerritbot added a comment.Feb 23 2021, 8:43 PM

Change 666437 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Amend 'search' size on canvas slightly

https://gerrit.wikimedia.org/r/666437

gerritbot added a project: Patch-For-Review.Feb 23 2021, 8:43 PM
gerritbot added a comment.Feb 23 2021, 9:04 PM

Change 666447 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] [icons] Amend 'search' icon

https://gerrit.wikimedia.org/r/666447

Volker_E updated the task description. (Show Details)Feb 23 2021, 9:19 PM
Volker_E removed a subscriber: • Petar.petkovic.
gerritbot added a comment.Feb 23 2021, 9:58 PM

Change 666437 merged by jenkins-bot:
[oojs/ui@master] icons: Amend 'search' size on canvas slightly

https://gerrit.wikimedia.org/r/666437

gerritbot added a comment.Feb 23 2021, 11:13 PM

Change 666488 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] icons: Update to latest 'search' icon and remove obsolete code

https://gerrit.wikimedia.org/r/666488

Pginer-WMF added a comment.Feb 24 2021, 8:41 AM
In T213580#6854329, @Volker_E wrote:

As of today, initiated by Desktop Improvements project work, we have a minor amendment to the 'search' icon which needs to be rolled out once more to all users of it.

Can you share the before and after versions in the ticket?

Thanks!

Volker_E updated the task description. (Show Details)Feb 24 2021, 10:19 AM

@Pginer-WMF Sure, was a late night driven attempt at first. Updated!

Volker_E updated the task description. (Show Details)Feb 24 2021, 10:21 AM
Volker_E added a project: Web-Team-Backlog (Kanbanana-FY-2020-21).Feb 24 2021, 10:25 AM
Pginer-WMF added a comment.Feb 24 2021, 10:29 AM
In T213580#6855698, @Volker_E wrote:

@Pginer-WMF Sure, was a late night driven attempt at first. Updated!

Was not an urgent request, but thanks a lot for the quick update!

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 24 2021, 5:28 PM
Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Feb 24 2021, 9:27 PM
Jdlrobson moved this task from Ready for Development to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson assigned this task to Volker_E.Mar 2 2021, 6:17 PM
Jdlrobson set the point value for this task to 3.
Jdlrobson moved this task from Upcoming to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson subscribed.

Medium risk given there are some variable changes.

gerritbot added a comment.Mar 2 2021, 6:40 PM

Change 666447 merged by jenkins-bot:
[mediawiki/skins/Vector@master] [icons] Amend 'search' icon

https://gerrit.wikimedia.org/r/666447

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 2 2021, 7:00 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 3 2021, 3:30 PM
Esanders unsubscribed.Mar 3 2021, 8:29 PM
Volker_E updated the task description. (Show Details)Mar 7 2021, 9:19 PM
Volker_E updated the task description. (Show Details)
Volker_E updated the task description. (Show Details)Mar 7 2021, 9:41 PM
Volker_E updated the task description. (Show Details)Mar 7 2021, 9:53 PM
gerritbot added a comment.Mar 7 2021, 11:25 PM

Change 669536 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Translate@master] Amend 'search' icon and fit into input

https://gerrit.wikimedia.org/r/669536

Volker_E updated the task description. (Show Details)Mar 8 2021, 1:45 PM
Volker_E updated the task description. (Show Details)Mar 8 2021, 1:50 PM
Volker_E updated the task description. (Show Details)Mar 8 2021, 2:53 PM
Volker_E added a subscriber: Nikerabbit.
Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 8 2021, 6:04 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog (Kanbanana-FY-2020-21).Mar 8 2021, 7:18 PM

All patches for reading web team repos are now merged.

Volker_E updated the task description. (Show Details)Mar 8 2021, 8:13 PM
Volker_E closed subtask T275563: Unify search icon to DSG standard one on mobile as Resolved.Mar 8 2021, 8:16 PM
gerritbot added a comment.Mar 9 2021, 9:11 AM

Change 666488 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] icons: Update to latest 'search' icon and remove obsolete code

https://gerrit.wikimedia.org/r/666488

gerritbot added a comment.Mar 9 2021, 12:45 PM

Change 669536 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Amend 'search' icon and fit into input

https://gerrit.wikimedia.org/r/669536

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 9 2021, 1:00 PM
Volker_E closed this task as Resolved.Mar 9 2021, 2:25 PM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
gerritbot added a comment.Mar 9 2021, 5:19 PM

Change 670240 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.41.2

https://gerrit.wikimedia.org/r/670240

gerritbot added a project: Patch-For-Review.Mar 9 2021, 5:19 PM
gerritbot added a comment.Mar 9 2021, 8:40 PM

Change 670240 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.41.2

https://gerrit.wikimedia.org/r/670240

• alexhollender_WMF mentioned this in T279015: [Visual bug] search icon increases in size when Vue loads.Mar 31 2021, 9:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL