Page MenuHomePhabricator

Use consistent 'search' icon across products
Closed, ResolvedPublic3 Estimated Story Points

Description

With T177432 we've got a search icon that seeks implementation everywhere:
New search icon added to Design Style Guide, slightly smaller, 18x18dp on 20x20dp canvas

BeforeAfter
image.png (534×1 px, 49 KB)
image.png (552×1 px, 49 KB)
image.png (420×1 px, 48 KB)
image.png (414×1 px, 48 KB)

Event Timeline

Volker_E triaged this task as Medium priority.Jan 11 2019, 9:26 PM
Volker_E created this task.

ext.cx.tools.less & ext.cx.tools.linker.less are part of old Content Translation codebase (CX1), which is now out there only to support editing of old translations which are started with CX1. After T212646, it is no longer possible to start new translations using CX1.

We don't make changes in CX1 codebase, which will be removed eventually.

Volker_E updated the task description. (Show Details)

As of today, initiated by Desktop Improvements project work, we have a minor amendment to the 'search' icon which needs to be rolled out once more to all users of it.

Change 666437 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] icons: Amend 'search' size on canvas slightly

https://gerrit.wikimedia.org/r/666437

Change 666447 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] [icons] Amend 'search' icon

https://gerrit.wikimedia.org/r/666447

Change 666437 merged by jenkins-bot:
[oojs/ui@master] icons: Amend 'search' size on canvas slightly

https://gerrit.wikimedia.org/r/666437

Change 666488 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] icons: Update to latest 'search' icon and remove obsolete code

https://gerrit.wikimedia.org/r/666488

As of today, initiated by Desktop Improvements project work, we have a minor amendment to the 'search' icon which needs to be rolled out once more to all users of it.

Can you share the before and after versions in the ticket?

Thanks!

@Pginer-WMF Sure, was a late night driven attempt at first. Updated!

@Pginer-WMF Sure, was a late night driven attempt at first. Updated!

Was not an urgent request, but thanks a lot for the quick update!

Jdlrobson set the point value for this task to 3.
Jdlrobson added a subscriber: Jdlrobson.

Medium risk given there are some variable changes.

Change 666447 merged by jenkins-bot:
[mediawiki/skins/Vector@master] [icons] Amend 'search' icon

https://gerrit.wikimedia.org/r/666447

Volker_E updated the task description. (Show Details)

Change 669536 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/Translate@master] Amend 'search' icon and fit into input

https://gerrit.wikimedia.org/r/669536

Change 666488 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] icons: Update to latest 'search' icon and remove obsolete code

https://gerrit.wikimedia.org/r/666488

Change 669536 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Amend 'search' icon and fit into input

https://gerrit.wikimedia.org/r/669536

Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)

Change 670240 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.41.2

https://gerrit.wikimedia.org/r/670240

Change 670240 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.41.2

https://gerrit.wikimedia.org/r/670240