Page MenuHomePhabricator

CX2: Make version 2 the only available
Open, HighPublic

Description

As part of the gradual deployment process for the new version of Content translation, we want the new version to become the only available:

  • Users of Content translation will always get version 2 when they start a new translation.
  • Options for users to enable/disable the new version will be removed from the UI. Including the "try the new version" link (T194387), the more prominent invite (T204817), and the possibility to select version 1 from the URL.
  • Translations already started with version 1 will still use version 1 editor if users continue editing them.

In this way, all new translations will be started with version 2, keeping version 1 only for backwards-compatibility (until T189091 removes all version 1 drafts, and version 1 can be completely removed).

This change will affect only a small portion of users, since more than 80% of the translations are created with the new version compared to the total published. Unlike T211325 (which message most of the already users already saw), no additional notification will be shown to the users. The tool will just get a set of improvements as it regularly does.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 27 2018, 11:56 AM
Pginer-WMF triaged this task as Normal priority.Dec 27 2018, 11:56 AM
Pginer-WMF updated the task description. (Show Details)Mar 12 2019, 11:00 AM
Pginer-WMF raised the priority of this task from Normal to High.Mar 18 2019, 11:55 AM

Change 497677 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Remove version switcher

https://gerrit.wikimedia.org/r/497677

Change 497677 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Remove version switcher

https://gerrit.wikimedia.org/r/497677

@Petar.petkovic is there anything else pending in this front? I tried with an account that was using CX1 and was correctly migrated to CX2.

@Petar.petkovic is there anything else pending in this front? I tried with an account that was using CX1 and was correctly migrated to CX2.

The merged patch removed the possibility to switch versions (and thus use CX1) from the UI, but you can still do it by manipulating the URL. When user starts new translation and changes version=2 param to version=1 in the URL, CX1 will load. That should not happen and should be prevented, but not sure if we should display some friendly message when users try that.

@Petar.petkovic is there anything else pending in this front? I tried with an account that was using CX1 and was correctly migrated to CX2.

The merged patch removed the possibility to switch versions (and thus use CX1) from the UI, but you can still do it by manipulating the URL. When user starts new translation and changes version=2 param to version=1 in the URL, CX1 will load. That should not happen and should be prevented, but not sure if we should display some friendly message when users try that.

Ok. Thanks for the update. I think a message is not needed. Version just becomes an irrelevant parameter in the URL. We just need to be sure that old translations can be continued with version 1.

Change 503423 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Remove version param from URL

https://gerrit.wikimedia.org/r/503423

Change 503423 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Remove version param from URL

https://gerrit.wikimedia.org/r/503423

Arrbee added a subscriber: Arrbee.Wed, Apr 17, 7:50 AM

@Petar.petkovic should this be moved to QA?

@Petar.petkovic should this be moved to QA?

Yes. I'm moving it to post deployment QA because it's on MediaWiki 1.34.0-wmf.1 train which should be deployed to group 2 wikis today.

To sum up what has been done in this ticket:

  • Options for users to choose between CX1 and CX2 is removed from the UI
  • All new translations can only be started by using CX2
  • Existing translations must continue with the original version used to start the translation process
  • Version parameter is no longer visible in the URL, but still exists in the codebase to support using different edit tags on articles published with CX and not to break event logging schemas and logging.