Page MenuHomePhabricator

SecurePoll: Target filter remains disabled when switching from "Voter log" to "All SecurePoll logs"
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

What is the problem?

When switching between "Voter log" and "All SecurePoll logs", the "Target (username)" input field remains disabled. It should become enabled when "All SecurePoll logs" is selected.

Steps to reproduce problem
  1. Go to Special:SecurePollLog
    • Notice the "Target (username)" field is enabled
  2. In the first dropdown, select "Voter log"
    • Notice the "Target (username)" field becomes disabled
  3. Select "All SecurePoll logs" again

Expected behavior: "Target (username)" field becomes enabled again
Observed behavior: "Target (username)" field remains disabled

Environment

Browser: Firefox 78
Wiki(s): local vagrant SecurePoll 2.0.0 (3f72a1b).

Screenshots (if applicable):

When you first go onto the Special:SecurePollLog page:


When you switch to "Voter log":

When you switch back to "All SecurePoll logs":

Event Timeline

Change 666742 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] Fix "target" filter disabled state when viewing "all"

https://gerrit.wikimedia.org/r/666742

Change 666742 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Fix "target" filter disabled state when viewing "all"

https://gerrit.wikimedia.org/r/666742

I can no longer reproduce the bug in the description.

I tested all the 6 transitions ("All SecurePoll logs" > "Voter log", "Voter log" > "Admin log", etc.)