i18n messages aren't available with Pywikibot package from pypi
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Feb 28 2021, 6:57 AM

Description

i18n messages are placed in scripts folder as submodule. They are not available with the pypi package and can fail therefore. There are those places with i18n usage in the pywkibot framework:
https://codesearch.wmcloud.org/pywikibot/?q=(pywikibot%7Ccosmetic_changes)-&i=nope&files=pywikibot&excludeFiles=&repos=

bot.py: fallback can be used for input statement
fixes.py: replace.py script is required to use fixes which is not available with pypi package
page.touch(): usually this method does not write and the summary could be hardcoded but i18n was introduced due to T199042
page.save(): appends cosmetic_changes message if enabled
pagegenerators.py: fallback messages are used here

See https://lists.wikimedia.org/pipermail/pywikibot/2021-February/010073.html

Details

Subject	Repo	Branch	Lines +/-
[i18n] Make pywikibot messages available with site package.	pywikibot/core	master	+105 -17
[bugfix] use hardcoded messages if i18n system is not available	pywikibot/core	master	+43 -8
[fix] Safely restore cosmetic_changes_mylang_only setting	pywikibot/core	master	+2 -3

Customize query in gerrit

Related Objects

Mentioned In: T305799: scripts version is no longer checked
rPWBC8da6b514c6e6: [fix] Safely restore cosmetic_changes_mylang_only setting
rPWBC2717d1afddcd: [bugfix] use hardcoded messages if i18n system is not available
Mentioned Here: T199042: touch.py makes empty edits on ProofreadPage pages

Event Timeline

Xqt created this task.Feb 28 2021, 6:57 AM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptFeb 28 2021, 6:57 AM

Xqt triaged this task as Medium priority.Feb 28 2021, 6:57 AM

Xqt updated the task description. (Show Details)Feb 28 2021, 7:04 AM

Xqt raised the priority of this task from Medium to High.Feb 28 2021, 7:07 AM

Xqt updated the task description. (Show Details)

Change 667372 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [bugfix] use hardcoded messages if i18n system is not available

https://gerrit.wikimedia.org/r/667372

gerritbot added a project: Patch-For-Review.Feb 28 2021, 7:29 AM

Xqt closed this task as Resolved.Feb 28 2021, 12:30 PM

Xqt claimed this task.

Change 667372 merged by jenkins-bot:
[pywikibot/core@master] [bugfix] use hardcoded messages if i18n system is not available

https://gerrit.wikimedia.org/r/667372

Xqt mentioned this in rPWBC2717d1afddcd: [bugfix] use hardcoded messages if i18n system is not available.Feb 28 2021, 12:45 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2021, 1:10 PM

Change 667385 had a related patch set uploaded (by Xqt; owner: Xqt):
[pywikibot/core@master] [fix] Safely restore cosmetic_changes_mylang_only setting

https://gerrit.wikimedia.org/r/667385

gerritbot added a project: Patch-For-Review.Feb 28 2021, 2:17 PM

Change 667385 merged by jenkins-bot:
[pywikibot/core@master] [fix] Safely restore cosmetic_changes_mylang_only setting

https://gerrit.wikimedia.org/r/667385

Xqt mentioned this in rPWBC8da6b514c6e6: [fix] Safely restore cosmetic_changes_mylang_only setting.Feb 28 2021, 2:48 PM

Maintenance_bot removed a project: Patch-For-Review.Feb 28 2021, 3:10 PM

Lokal_Profil awarded a token.Feb 28 2021, 7:19 PM

Reopened. i18n can be added to the Pywikibot framework

Change 750457 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [i18n] Make pywikibot messages available with site package.

https://gerrit.wikimedia.org/r/750457

gerritbot added a project: Patch-For-Review.Dec 28 2021, 5:32 PM

Xqt closed this task as Resolved.Jan 4 2022, 11:26 AM

Change 750457 merged by jenkins-bot: