Page MenuHomePhabricator
Create Task
Maniphest T276077

Port TranslatePage to have service dependencies
Closed, ResolvedPublic
Actions

Description

Following T275648: Allow services to be injected into SecurePoll ActionPages, inject service dependencies via the TranslatePage constructor.

See T276076: Port CreatePage to have service dependencies for an example of how to do this.

Details

SubjectRepoBranchLines +/-
Port TranslatePage to have service dependenciesmediawiki/extensions/SecurePollmaster+35 -14
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Mar 1 2021, 11:58 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2021, 11:58 AM
Tchanders updated the task description. (Show Details)Mar 1 2021, 11:58 AM
• AGueyte claimed this task.Mar 1 2021, 2:10 PM
• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Mar 1 2021, 10:17 PM

Change 667719 had a related patch set uploaded (by AGueyte; owner: AGueyte):
[mediawiki/extensions/SecurePoll@master] Port TranslatePage to have service dependencies

https://gerrit.wikimedia.org/r/667719

gerritbot added a project: Patch-For-Review.Mar 1 2021, 10:17 PM
• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Mar 1 2021, 10:20 PM
Tchanders moved this task from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Mar 4 2021, 12:58 PM
gerritbot added a comment.Mar 4 2021, 1:18 PM

Change 667719 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Port TranslatePage to have service dependencies

https://gerrit.wikimedia.org/r/667719

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.34; 2021-03-09).Mar 4 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 4 2021, 2:10 PM
Niharika closed this task as Resolved.Mar 4 2021, 4:17 PM
Reedy mentioned this in T287780: SecurePoll CreatePage can no longer correctly select "remote" wiki databases that aren't in the same cluster.Jul 30 2021, 9:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL