Page MenuHomePhabricator
Create Task
Maniphest T276076

Port CreatePage to have service dependencies
Closed, ResolvedPublic
Actions

Description

Following T275648: Allow services to be injected into SecurePoll ActionPages, inject service dependencies via the CreatePage constructor.

Details

SubjectRepoBranchLines +/-
Port CreatePage to have service dependenciesmediawiki/extensions/SecurePollmaster+31 -13
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Mar 1 2021, 11:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2021, 11:57 AM
Tchanders mentioned this in T276077: Port TranslatePage to have service dependencies.Mar 1 2021, 11:58 AM
Tchanders mentioned this in T276078: Port VoterEligibilityPage to have service dependencies.
Tchanders mentioned this in T276079: Port EntryPage to have service dependencies.
Tchanders mentioned this in T276080: Port VotePage to have service dependencies.Mar 1 2021, 12:01 PM
gerritbot added a comment.Mar 1 2021, 12:07 PM

Change 667232 had a related patch set uploaded (by Tchanders; owner: DLynch):
[mediawiki/extensions/SecurePoll@master] Port CreatePage to have service dependencies

https://gerrit.wikimedia.org/r/667232

gerritbot added a project: Patch-For-Review.Mar 1 2021, 12:07 PM
Tchanders assigned this task to DLynch.Mar 1 2021, 12:10 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.
Tchanders mentioned this in T275648: Allow services to be injected into SecurePoll ActionPages.
Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Mar 1 2021, 10:14 PM
gerritbot added a comment.Mar 1 2021, 10:28 PM

Change 667232 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Port CreatePage to have service dependencies

https://gerrit.wikimedia.org/r/667232

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 1 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2021, 11:10 PM
Tchanders moved this task from QA/Testing 🐞 to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Mar 4 2021, 6:33 PM

I checked the polls are created correctly on the local and remote wikis. There's probably not much more to test here, so moving on from QA since the column is quite full.

Niharika closed this task as Resolved.Mar 16 2021, 1:49 PM
dom_walden mentioned this in T278138: SecurePoll: Field 'el_owner' doesn't have a default value.Mar 23 2021, 9:05 AM
Reedy mentioned this in T287780: SecurePoll CreatePage can no longer correctly select "remote" wiki databases that aren't in the same cluster.Jul 30 2021, 6:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits