Page MenuHomePhabricator

Port VoterEligibilityPage to have service dependencies
Closed, ResolvedPublic

Description

Following T275648: Allow services to be injected into SecurePoll ActionPages, inject service dependencies via the VoterEligibilityPage constructor.

See T276076: Port CreatePage to have service dependencies for an example of how to do this.

Event Timeline

Change 667878 had a related patch set uploaded (by TsepoThoabala; owner: TsepoThoabala):
[mediawiki/extensions/SecurePoll@master] Port VoterEligibilityPage to have service dependencies

https://gerrit.wikimedia.org/r/667878

Change 667878 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Port VoterEligibilityPage to have service dependencies

https://gerrit.wikimedia.org/r/667878

dom_walden added a subscriber: dom_walden.

I used various functions on the voter eligibility page including:

  • Adding voter requirements from "Basic options"
  • Adding voter requirements from the "Eligibility list" (i.e. the "populate automatically" ones)
  • Editing and clearing the Eligibility, Override and Exclude lists (e.g. Special:SecurePoll/votereligibility/$id/edit/voter or Special:SecurePoll/votereligibility/$id/clear/voter)

I checked that the appropriate values were added and updated in the database and the respective SecurePoll namespace pages (e.g. SecurePoll:$id, SecurePoll:$id/list/need-list).

For a remote election, the voter eligibility page appears to update voter eligibility on the database of each connected election (not just the local one). I was not able to test this, however, as T278138 means I cannot created remote elections on beta. When that is fixed, I will try to retest this.

Test environment: https://vote.wikimedia.beta.wmflabs.org SecurePoll 2.0.0 (3242ab5) 07:58, 22 March 2021

For a remote election, the voter eligibility page appears to update voter eligibility on the database of each connected election (not just the local one). I was not able to test this, however, as T278138 means I cannot created remote elections on beta. When that is fixed, I will try to retest this.

I have retested this on beta. The voter eligibility settings are updated on connected wikis.