As of March 2021 EntitySavingHelper (and respectively its "parent" EntityLoadingHelper) class, which is meant as a "helper" service for API classes, knows - in the form of dependency - about the Action API "module" (i.e. PHP class) that uses the helper service.
This is not a good design: It creates a circular dependency. "Helper" service should not know where is being use - dependency should only be from API class depending on the service.
It seems that the "helper" classes use the API module to get some details about the API endpoint (apiModule->isWriteMode()), or to get the parameters of the particular API request (apiModule->extractRequestParams).
Acceptance criteria⛺✨ :
- EntitySavingHelper and EntityLoadingHelper do not know about/do not depend on the API module that uses them. Dependency only goes from the API class to the "helper" service