Page MenuHomePhabricator

allimages uses dbkey form where all pages and imageinfo uses title.
Closed, ResolvedPublic


I noticed that allimages is apparently the only API command that returns name= instead of title= and it uses the DbKey form (with _ ) instead of the title form of the images. This seems like an oversight to me.

Version: 1.17.x
Severity: trivial



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:14 PM
bzimport set Reference to bz25832.

matthew.britton wrote:

Allpages and imageinfo work with titles, for which both an "ns" and a "title", which includes the namespace, are output.

Allimages works with file names. Notice no namespace in the name= output, or in the aifrom parameter.

Allimages could be changed to work with titles too, but removing name= in favor of title= would be a breaking change, so should probably be avoided in case existing clients rely on it. Similarly, changing name= to output a title would mean more than just the underscores disappearing, as a "File:" prefix would be added.

Outputting both name= *and* title= (and a superfluous ns="6" for every file) seems redundant.

Bryan.TongMinh wrote:

I'm not really opposed to the redundant solution. Other opinions?

Bryan, care to implement the redundant solution?

Bryan.TongMinh wrote:

(In reply to comment #3)

Bryan, care to implement the redundant solution?

Not at this moment, maybe later.