Page MenuHomePhabricator
Create Task
Maniphest T278362

Remove redundant indicator styling rule in Vector
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
Jdlrobson
Mar 24 2021, 6:01 PM
Tags
Referenced Files
F34375691: Screen Shot 2021-04-13 at 6.43.55 AM.png
Apr 13 2021, 1:47 PM
F34375687: Screen Shot 2021-04-13 at 6.43.32 AM.png
Apr 13 2021, 1:47 PM
F34375721: Screen Shot 2021-04-13 at 6.47.00 AM.png
Apr 13 2021, 1:47 PM
F34375723: Screen Shot 2021-04-13 at 6.46.35 AM.png
Apr 13 2021, 1:47 PM
F34215398: Screen Shot 2021-04-02 at 3.38.00 PM.png
Apr 2 2021, 8:39 PM
Subscribers
Aklapper
bwang
Edtadros
Jdlrobson
olga
ovasileva

Description

T199035 added a float: right rule to indicators inside the interface ResourceLoaderSkinModule feature.

As a result the following rule in Vector is now redundant:

.mw-indicators {
       float: right;
}

Acceptance criteria

  • Rule is removed from resources/skins.vector.styles/legacy/layout.less
  • Rule is removed from resources/skins.vector.styles/layout-default.less

QA

Check both Vector versions.

QA Results - Beta

ACStatusDetails
1✅T278362#6994312
2✅T278362#6994312

Details

SubjectRepoBranchLines +/-
Remove redundant mw-indicator styles from `layout-default.less` and `layout.less`mediawiki/skins/Vectormaster+0 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Mar 24 2021, 6:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 24 2021, 6:01 PM
Jdlrobson updated the task description. (Show Details)Mar 24 2021, 6:01 PM
Jdlrobson mentioned this in T199035: Core should provide default page status indicator CSS inside the `interface` feature.Mar 24 2021, 6:05 PM
Jdlrobson assigned this task to ovasileva.Mar 24 2021, 11:06 PM
Jdlrobson triaged this task as Medium priority.
Jdlrobson lowered the priority of this task from Medium to Low.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
ovasileva moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.Mar 25 2021, 9:04 AM
Jdlrobson moved this task from Needs triage to Technical on the Vector (legacy skin) board.Mar 25 2021, 5:09 PM
bwang claimed this task.Apr 1 2021, 8:38 PM
bwang added a subscriber: ovasileva.
bwang added a comment.Apr 2 2021, 8:39 PM
This comment was removed by bwang.
bwang set the point value for this task to 2.Apr 2 2021, 8:39 PM
gerritbot added a comment.Apr 5 2021, 4:10 PM

Change 676642 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove redundant mw-indicator styles

https://gerrit.wikimedia.org/r/676642

gerritbot added a project: Patch-For-Review.Apr 5 2021, 4:10 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Apr 5 2021, 5:23 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang changed the point value for this task from 2 to 1.Apr 5 2021, 5:52 PM
Jdlrobson added a comment.Apr 5 2021, 11:23 PM

will review this tomorrow.

Jdlrobson reassigned this task from bwang to Edtadros.Apr 6 2021, 9:01 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: bwang.
gerritbot added a comment.Apr 6 2021, 9:25 PM

Change 676642 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove redundant mw-indicator styles from `layout-default.less` and `layout.less`

https://gerrit.wikimedia.org/r/676642

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 6 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 6 2021, 10:10 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.EditedApr 13 2021, 1:47 PM

@bwang please take a look at the screenshots and let me know if this is what you were looking for as expected results.

Test Result - Beta

Status: ✅ Need More Info
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Check both Vector versions.

✅ AC1: visit https://en.wikipedia.beta.wmflabs.org/wiki/Test_indicators?useskinversion=1 and confirm indicators are floated to the right.

Screen Shot 2021-04-13 at 6.43.32 AM.png (434×1 px, 118 KB)

Screen Shot 2021-04-13 at 6.47.00 AM.png (49×401 px, 8 KB)

✅ AC2: visit https://en.wikipedia.beta.wmflabs.org/wiki/Test_indicators?useskinversion=2 and confirm indicators are floated to the right.
Screen Shot 2021-04-13 at 6.43.55 AM.png (524×1 px, 116 KB)

Screen Shot 2021-04-13 at 6.46.35 AM.png (50×402 px, 8 KB)

Edtadros updated the task description. (Show Details)Apr 13 2021, 1:49 PM
Edtadros moved this task from QA in Prod to QA on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 13 2021, 1:59 PM
Edtadros updated the task description. (Show Details)
bwang added a comment.Apr 13 2021, 3:34 PM

@Edtadros Yes this looks right! The indicator should be floating to the right before and after the change.

Edtadros updated the task description. (Show Details)Apr 13 2021, 4:08 PM
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Edtadros reassigned this task from Edtadros to ovasileva.Apr 15 2021, 3:08 AM
Edtadros added subscribers: olga, Edtadros.

@olga this is a language button task.

ovasileva closed this task as Resolved.Apr 15 2021, 2:37 PM
ovasileva added a parent task: T256023: [EPIC] Improve language switching capabilities.
Jdlrobson moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Jun 9 2021, 9:22 PM
• IN mentioned this in T287364: Abnormally long loading times for enwiki.Jul 26 2021, 10:51 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits