Page MenuHomePhabricator

Remove redundant indicator styling rule in Vector
Closed, ResolvedPublic1 Estimated Story Points

Description

T199035 added a float: right rule to indicators inside the interface ResourceLoaderSkinModule feature.

As a result the following rule in Vector is now redundant:

.mw-indicators {
       float: right;
}

Acceptance criteria

  • Rule is removed from resources/skins.vector.styles/legacy/layout.less
  • Rule is removed from resources/skins.vector.styles/layout-default.less

QA

Check both Vector versions.

QA Results - Beta

ACStatusDetails
1T278362#6994312
2T278362#6994312

Event Timeline

Jdlrobson triaged this task as Medium priority.
Jdlrobson lowered the priority of this task from Medium to Low.
Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.
This comment was removed by bwang.
bwang set the point value for this task to 2.Apr 2 2021, 8:39 PM

Change 676642 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Remove redundant mw-indicator styles

https://gerrit.wikimedia.org/r/676642

bwang changed the point value for this task from 2 to 1.Apr 5 2021, 5:52 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: bwang.

Change 676642 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Remove redundant mw-indicator styles from `layout-default.less` and `layout.less`

https://gerrit.wikimedia.org/r/676642

@bwang please take a look at the screenshots and let me know if this is what you were looking for as expected results.

Test Result - Beta

Status: ✅ Need More Info
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Check both Vector versions.

✅ AC1: visit https://en.wikipedia.beta.wmflabs.org/wiki/Test_indicators?useskinversion=1 and confirm indicators are floated to the right.

Screen Shot 2021-04-13 at 6.43.32 AM.png (434×1 px, 118 KB)

Screen Shot 2021-04-13 at 6.47.00 AM.png (49×401 px, 8 KB)

✅ AC2: visit https://en.wikipedia.beta.wmflabs.org/wiki/Test_indicators?useskinversion=2 and confirm indicators are floated to the right.
Screen Shot 2021-04-13 at 6.43.55 AM.png (524×1 px, 116 KB)

Screen Shot 2021-04-13 at 6.46.35 AM.png (50×402 px, 8 KB)

@Edtadros Yes this looks right! The indicator should be floating to the right before and after the change.

Edtadros added subscribers: olga, Edtadros.

@olga this is a language button task.