Add a link: context item is set up and torn down right after on desktop (sometimes)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• mewoph
	Apr 2 2021, 8:19 PM

Description

Steps to Reproduce:

Enable link recommendations
Click on task card from Special:Homepage

Actual Results:
Link recommendation annotations are highlighted in the article, but the corresponding context item doesn't show up. This happens some of the time in Chrome and Firefox.

Expected Results:
Corresponding context item is opened and isn't torn down until the user clicks outside the context item.

Screen recording:
https://drive.google.com/file/d/14uYPBJlcmZwq1b8qETcI9fZ9lBcNRb1Y/view?usp=sharing

At 00:14, the context item can be seen briefly before it was torn down.

Screen Shot 2021-04-02 at 1.16.38 PM.png (1×2 px, 1 MB)

Logs from console:

after activate ve load.php:938:143
done setting up recommended link context item at 1617394079498 load.php:395:977
tearing down LinearContextItem at 1617394079658 load.php:787:866

Logs with stack trace:

firefox-console-export.txt13 KBDownload

Details

	Subject	Repo	Branch	Lines +/-
	Add a link: make sure annotation is selected after page is focused	mediawiki/extensions/GrowthExperiments	master	+8 -1

Customize query in gerrit

Related Objects

Mentioned In: T278484: Inspector does not always open, and nothing is logged in console
T278889: Add a link: Context item doesn't appear when VE loads on Safari (desktop)

Event Timeline

• mewoph created this task.Apr 2 2021, 8:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2021, 8:19 PM

• mewoph mentioned this in T278889: Add a link: Context item doesn't appear when VE loads on Safari (desktop).Apr 2 2021, 8:21 PM

Looking further into VE's code, it looks like the surface is focused in ve.init.mw.DesktopArticleTarget.prototype.afterActivate (which then eventually calls surface.getModel().selectFirstContentOffset(); in the next run loop). This does seem explain why the context item is set up and torn down right away (when the context item is already open, focusing anywhere outside of the context item closes the currently opened context item)

done setting up RecommendedLinkContextItem at 1617401089942 load.php:395:977
ve.ce.Surface.prototype.focus 1617401090012 load.php:504:353
selectFirstContentOffset load.php:240:633
tearing down LinearContextItem at 1617401090083
window.getSelection().focusNode

When this issue occurs, the focusNode is NOT the expected annotation.

We should make sure that the annotation is selected AFTER DesktopArticleTarget focuses on the page so that the context item doesn't get closed by the subsequent focus.

Change 676686 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: make sure annotation is selected after page is focused

https://gerrit.wikimedia.org/r/676686

gerritbot added a project: Patch-For-Review.Apr 2 2021, 10:31 PM

• mewoph moved this task from Backlog to April 5 - April 9 on the Add-Link board.Apr 2 2021, 10:31 PM

• mewoph claimed this task.Apr 5 2021, 4:45 PM

• mewoph mentioned this in T278484: Inspector does not always open, and nothing is logged in console.Apr 5 2021, 4:48 PM

Tgr merged a task: T278484: Inspector does not always open, and nothing is logged in console.Apr 5 2021, 4:52 PM

Tgr added subscribers: kostajh, Tgr.

• mewoph edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Apr 5 2021, 5:50 PM

• mewoph moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh moved this task from April 5 - April 9 to Done / QA on the Add-Link board.Apr 6 2021, 12:41 PM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 676686 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: make sure annotation is selected after page is focused

https://gerrit.wikimedia.org/r/676686

Maintenance_bot removed a project: Patch-For-Review.Apr 6 2021, 2:10 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 6 2021, 5:00 PM

Checked in testwiki wmf.37.

	F34215376: Screen Shot 2021-04-02 at 1.16.38 PM.png
	Apr 2 2021, 8:19 PM

Add a link: context item is set up and torn down right after on desktop (sometimes)Closed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Add a link: context item is set up and torn down right after on desktop (sometimes)
Closed, ResolvedPublicBUG REPORT
Actions