Page MenuHomePhabricator
Create Task
Maniphest T279855

Ws-export: Hide export menu in edit mode
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In edit mode, the export options still show up. This pushes other tools down the page and is not useful in that mode.

This can probably be circumvented in JS, but it would be tidier to do it on the server side.

Original request: https://en.wikisource.org/w/index.php?title=Wikisource:Administrators%27_noticeboard&diff=11178261&oldid=11176170

Details

SubjectRepoBranchLines +/-
Don't show export links in sidebar during editingmediawiki/extensions/Wikisourcemaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Inductiveload created this task.Apr 11 2021, 2:25 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptApr 11 2021, 2:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwilson moved this task from Backlog to Ready to work on on the WS Export board.May 3 2021, 10:50 PM
gerritbot added a comment.Jul 28 2021, 1:58 AM

Change 708389 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Wikisource@master] Don't show export links in sidebar during editing

https://gerrit.wikimedia.org/r/708389

gerritbot added a project: Patch-For-Review.Jul 28 2021, 1:58 AM
Samwilson claimed this task.Jul 28 2021, 1:59 AM
Samwilson set the point value for this task to 1.
Samwilson edited projects, added Community-Tech (CommTech-Sprint-5); removed Community-Tech.
Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-5) board.
MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-5) board.Jul 30 2021, 4:42 PM
gerritbot added a comment.Jul 30 2021, 5:06 PM

Change 708389 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] Don't show export links in sidebar during editing

https://gerrit.wikimedia.org/r/708389

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2021, 5:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Jul 30 2021, 6:00 PM
ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-6); removed Community-Tech (CommTech-Sprint-5).Aug 2 2021, 6:09 PM
ldelench_wmf moved this task from Ready 🎬 to QA 🐛 on the Community-Tech (CommTech-Sprint-6) board.
dom_walden closed this task as Resolved.Aug 10 2021, 1:31 PM
dom_walden moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Sprint-6) board.
dom_walden subscribed.

With the editor open on https://en.wikisource.org, the sidebar does not contain the "Download/print" options. I tested both Source and Visual editor, on every skin.

Test Environment: https://en.wikisource.org MediaWiki 1.37.0-wmf.17 (rMW730ddbb90c6f) 18:07, 5 August 2021

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL