Page MenuHomePhabricator
Create Task
Maniphest T280522

Allow partial action blocks to be performed via ApiBlock
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

T279556 introduces infrastructure for making partial blocks against actions.

It should be possible to do this via the API as well as via the SpecialPage. Handling in the SpecialPage is introduced in the original patch; this task is for the API.

What needs to be done?

  • ApiBlock should recognise a new parameter actionrestrictions in addition to the existing pagerestrictions and namespacerestrictions
  • Allowed values should be the values returned by the BlockActionInfo service
  • Action restrictions should be added into the $restrictions array passed to the BlockUser object.

Details

SubjectRepoBranchLines +/-
Allow partial action blocks to be made via ApiBlockmediawiki/coremaster+86 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tchanders created this task.Apr 19 2021, 12:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 19 2021, 12:38 PM
Tchanders added a subtask: T279556: Introduce infrastructure for making partial blocks against actions.Apr 19 2021, 12:39 PM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Apr 21 2021, 1:45 PM
ARamirez_WMF set the point value for this task to 3.Apr 21 2021, 4:22 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Apr 21 2021, 5:00 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
Tchanders mentioned this in T279556: Introduce infrastructure for making partial blocks against actions.Apr 28 2021, 11:29 AM
Tchanders updated the task description. (Show Details)Apr 29 2021, 2:39 PM
Tchanders claimed this task.Apr 29 2021, 2:45 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Apr 29 2021, 4:35 PM

Change 683684 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/core@master] Allow partial action blocks to be made via ApiBlock

https://gerrit.wikimedia.org/r/683684

gerritbot added a project: Patch-For-Review.Apr 29 2021, 4:35 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Apr 29 2021, 4:35 PM
gerritbot added a comment.May 4 2021, 6:21 PM

Change 683684 merged by jenkins-bot:

[mediawiki/core@master] Allow partial action blocks to be made via ApiBlock

https://gerrit.wikimedia.org/r/683684

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.May 4 2021, 6:36 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.5; 2021-05-11).May 4 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 4 2021, 7:10 PM
dom_walden moved this task from QA/Testing 🐞 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.May 5 2021, 2:34 PM
dom_walden subscribed.

I have been able to use the API to create blocks against the upload, move and create actions.

You pass the name of the action (e.g. create) to the API. If this is invalid, it returns a warning but otherwise creates the block (ignoring whichever action restrictions were invalid). This is very much like namespace restrictions.

Test environment: various beta wikis, MediaWiki 1.37.0-alpha (bb285a7) 06:37, 5 May 2021.

Tchanders closed this task as Resolved.May 11 2021, 8:41 PM
Tchanders closed subtask T279556: Introduce infrastructure for making partial blocks against actions as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits