Page MenuHomePhabricator

Show Suggested Values field if the type should allow it
Closed, ResolvedPublic2 Estimated Story Points

Description

Bug description
Ran into a bug when testing on beta by editing the existing TemplateData for Infobox person in the TemplateData Editor:

  • Suggested values field didn't show for parameters with the types for which it should be enabled, until I clicked on and re-selected the type or selected another type for which it is enabled. Only after I interacted with the "type" field would the suggested values field show below it.
  • I also tested with adding new TemplateData and new parameters. They are set by default to type "Unknown", which should then show the suggested values field in the TemplateData Editor automatically, but I still had to do the same work around to get it to appear. (recorded screen to show this)

Required behavior

  • If a parameter is set to one of the types where Suggested Values should be visible, this field is visible in the TemplateData Editor without the user taking any action.

Event Timeline

ECohen_WMDE renamed this task from Show Suggested Values field for existing parameters if the type matches to Show Suggested Values field if the type should show allow it.Tue, Apr 20, 3:26 PM
Lena_WMDE updated the task description. (Show Details)
Lena_WMDE renamed this task from Show Suggested Values field if the type should show allow it to Show Suggested Values field if the type should allow it.Wed, Apr 21, 6:54 AM

We might want to backport the potential patch to be sure it's there when released on the 29th.

Change 681932 had a related patch set uploaded (by Andrew-WMDE; author: Andrew-WMDE):

[mediawiki/extensions/TemplateData@master] Fix suggested values not being shown when the param's type isn't specified

https://gerrit.wikimedia.org/r/681932

Change 681932 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Fix suggested values not being shown when the param's type isn't specified

https://gerrit.wikimedia.org/r/681932

Change 681969 had a related patch set uploaded (by WMDE-Fisch; author: Andrew-WMDE):

[mediawiki/extensions/TemplateData@wmf/1.37.0-wmf.1] Fix suggested values not being shown when the param's type isn't specified

https://gerrit.wikimedia.org/r/681969

Backport scheduled for Monday 1pm window so we're save that the fix is present even when the train gets stuck.

https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1909312&oldid=1909239

Change 682091 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TemplateData@master] Inline fix for suggested values on unkown paramter types

https://gerrit.wikimedia.org/r/682091

Change 682091 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Inline fix for suggested values on unkown paramter types

https://gerrit.wikimedia.org/r/682091

Change 681969 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@wmf/1.37.0-wmf.1] Fix suggested values not being shown when the param's type isn't specified

https://gerrit.wikimedia.org/r/681969

Mentioned in SAL (#wikimedia-operations) [2021-04-26T11:45:04Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.1/extensions/TemplateData/modules/ext.templateDataGenerator.editTemplatePage/Dialog.js: a347517f906b07b2503ae559c6cc714e1c50e4aa: Fix suggested values not being shown when the params type isnt specified (T280688) (duration: 00m 57s)

Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-04-14 board.