Maniphest T281394

Hard-deprecate User::whoIs
Open, LowPublic
Actions

Assigned To

None

Authored By

	• Pchelolo
	Apr 28 2021, 5:47 PM

Tags

Referenced Files

None

Subscribers

Description

The method uses global state (bad) and with ActorStore introduction we can use UserIdentityLookup to fetch UserIdentity by user ID and get it's name. This will benefit from charing the in-process cache with everything else.

Deployed extensions:

FlaggedRevs https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/683709
Jade T281418

Third-party extensions:

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+156 -148	Hard-deprecate UserCache and User::whoIs methods.
	mediawiki/extensions/FlaggedRevs	master	+16 -8	Remove usages of User::whoIs - getting deprecated.

Customize query in gerrit

Related Objects

Mentioned Here: T281418: Undeploy JADE extension from beta cluster

Event Timeline

• Pchelolo created this task.Apr 28 2021, 5:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2021, 5:47 PM

• Pchelolo updated the task description. (Show Details)Apr 28 2021, 5:53 PM

Change 683709 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/FlaggedRevs@master] Remove usages of User::whoIs - getting deprecated.

https://gerrit.wikimedia.org/r/683709

gerritbot added a project: Patch-For-Review.Apr 29 2021, 7:36 PM

• Pchelolo updated the task description. (Show Details)Apr 29 2021, 7:37 PM

Change 683020 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] Hard-deprecate UserCache and User::whoIs methods.

https://gerrit.wikimedia.org/r/683020

Change 683709 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Remove usages of User::whoIs - getting deprecated.

https://gerrit.wikimedia.org/r/683709

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 14 2021, 5:00 AM

• Pchelolo moved this task from Unsorted pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.May 25 2021, 1:42 PM

daniel triaged this task as Low priority.Wed, Jun 29, 10:54 AM

Removing inactive assignee (Platform Engineering: Please unassign tasks of previous team members.)