Hard-deprecate User::whoIs/whoIsReal (and remove in 1.45)
Closed, ResolvedPublic
Actions

Description

The method uses global state (bad) and with ActorStore introduction we can use UserIdentityLookup to fetch UserIdentity by user ID and get it's name. This will benefit from charing the in-process cache with everything else.

Deployed extensions:

FlaggedRevs https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/683709
Jade T281418
GlobalBlocking

Third-party extensions:

CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbUser%5Cs*%3A%3A%5Cs*whoIs%5Cb&files=&excludeFiles=&repos=&i=fosho

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
user: Remove hard-deprecated User::whoIs/whoIsReal	mediawiki/core	master	+1 -29
user: Hard-deprecate User::whoIs/whoIsReal	mediawiki/core	master	+7 -2
Hard-deprecate UserCache and User::whoIs methods.	mediawiki/core	master	+156 -148
Replace User::whoIs with UserFactory::newFromId	mediawiki/extensions/ConfirmAccount	master	+7 -4
Replace User::whoIs with UserFactory::newFromId	mediawiki/extensions/BatchUserRights	master	+5 -3
Replace User::whoIs with UserFactory::newFromId	mediawiki/extensions/NewUserNotif	master	+4 -2
Deprecate User::whoIs/whoIsReal	mediawiki/core	master	+3 -0
Remove usages of User::whoIs - getting deprecated.	mediawiki/extensions/FlaggedRevs	master	+16 -8

Customize query in gerrit

Related Objects

Mentioned In: rENUN4d4b4d8907d7: Replace User::whoIs with UserFactory::newFromId
rECAC9fcdbfda3d2d: Replace User::whoIs with UserFactory::newFromId
Mentioned Here: T281418: Undeploy JADE extension from beta cluster

Event Timeline

• Pchelolo created this task.Apr 28 2021, 5:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 28 2021, 5:47 PM

• Pchelolo updated the task description. (Show Details)Apr 28 2021, 5:53 PM

Change 683709 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/FlaggedRevs@master] Remove usages of User::whoIs - getting deprecated.

https://gerrit.wikimedia.org/r/683709

gerritbot added a project: Patch-For-Review.Apr 29 2021, 7:36 PM

• Pchelolo updated the task description. (Show Details)Apr 29 2021, 7:37 PM

Change 683020 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] Hard-deprecate UserCache and User::whoIs methods.

https://gerrit.wikimedia.org/r/683020

Change 683709 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Remove usages of User::whoIs - getting deprecated.

https://gerrit.wikimedia.org/r/683709

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.6; 2021-05-18).May 14 2021, 5:00 AM

• Pchelolo moved this task from Unsorted pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.May 25 2021, 1:42 PM

daniel triaged this task as Low priority.Jun 29 2022, 10:54 AM

Removing inactive assignee (Platform Engineering: Please unassign tasks of previous team members.)

Umherirrender updated the task description. (Show Details)Dec 29 2022, 10:03 PM

Change 941519 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BatchUserRights@master] Use cross-wiki aware UserIdentityLookup on Special:BatchUserRights

https://gerrit.wikimedia.org/r/941519

Pppery edited projects, added Patch-Needs-Improvement, MediaWiki-User-management; removed Patch-For-Review.Oct 10 2023, 5:33 AM

Change #1050687 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/NewUserNotif@master] Replace User::whoIs with UserFactory::newFromId

https://gerrit.wikimedia.org/r/1050687

gerritbot added a project: Patch-For-Review.Jun 29 2024, 9:45 AM

Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptJun 29 2024, 9:45 AM

Change #1050692 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/BatchUserRights@master] Replace User::whoIs with UserFactory::newFromId

https://gerrit.wikimedia.org/r/1050692

Umherirrender renamed this task from Hard-deprecate User::whoIs to Hard-deprecate User::whoIs/whoIsReal.Jun 29 2024, 9:55 AM

Umherirrender updated the task description. (Show Details)

Change #1050693 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ConfirmAccount@master] Replace User::whoIs with UserFactory::newFromId

https://gerrit.wikimedia.org/r/1050693

Change #1050694 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Deprecate User::whoIs/whoIsReal

https://gerrit.wikimedia.org/r/1050694

Change #1050694 merged by jenkins-bot:

[mediawiki/core@master] Deprecate User::whoIs/whoIsReal

https://gerrit.wikimedia.org/r/1050694

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Jul 2 2024, 6:00 PM

Change #1050687 merged by jenkins-bot:

[mediawiki/extensions/NewUserNotif@master] Replace User::whoIs with UserFactory::newFromId

https://gerrit.wikimedia.org/r/1050687

Change #1050692 merged by jenkins-bot:

[mediawiki/extensions/BatchUserRights@master] Replace User::whoIs with UserFactory::newFromId

https://gerrit.wikimedia.org/r/1050692

Change #1050693 merged by jenkins-bot:

[mediawiki/extensions/ConfirmAccount@master] Replace User::whoIs with UserFactory::newFromId

https://gerrit.wikimedia.org/r/1050693

Umherirrender changed the task status from Open to Stalled.Jul 7 2024, 8:25 AM

Umherirrender edited projects, added MW-1.44-release; removed Patch-For-Review.

Umherirrender updated the task description. (Show Details)

Umherirrender mentioned this in rECAC9fcdbfda3d2d: Replace User::whoIs with UserFactory::newFromId.Jul 7 2024, 8:26 AM

Umherirrender mentioned this in rENUN4d4b4d8907d7: Replace User::whoIs with UserFactory::newFromId.Jul 7 2024, 9:56 AM

Umherirrender moved this task from Blocker to Deprecate or remove on the MW-1.44-release board.Jul 23 2024, 2:05 PM

Change #683020 abandoned by Umherirrender:

[mediawiki/core@master] Hard-deprecate UserCache and User::whoIs methods.

Reason:

Was done in Ie5456a09bbf8ab0f236157182309cea8bedd9359

https://gerrit.wikimedia.org/r/683020

Dreamy_Jazz updated the task description. (Show Details)Oct 14 2024, 1:31 PM

Dreamy_Jazz updated the task description. (Show Details)

Umherirrender changed the task status from Stalled to Open.Apr 7 2025, 6:50 PM

Umherirrender claimed this task.

Umherirrender updated the task description. (Show Details)

Change #1134752 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] user: Hard-deprecate User::whoIs/whoIsReal

https://gerrit.wikimedia.org/r/1134752

gerritbot added a project: Patch-For-Review.Apr 7 2025, 6:54 PM

Change #1134752 merged by jenkins-bot:

[mediawiki/core@master] user: Hard-deprecate User::whoIs/whoIsReal

https://gerrit.wikimedia.org/r/1134752

Umherirrender renamed this task from Hard-deprecate User::whoIs/whoIsReal to Hard-deprecate User::whoIs/whoIsReal (and remove in 1.45).Apr 17 2025, 9:59 PM

Umherirrender changed the task status from Open to Stalled.

Umherirrender removed Umherirrender as the assignee of this task.

Umherirrender removed a project: Patch-For-Review.

Umherirrender subscribed.

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).Apr 17 2025, 10:00 PM

Umherirrender changed the task status from Stalled to Open.May 6 2025, 8:21 PM

Umherirrender edited projects, added MW-1.45-release; removed MW-1.44-release.

Umherirrender moved this task from Blocker to Deprecate or remove on the MW-1.45-release board.

Umherirrender claimed this task.Jun 3 2025, 7:59 PM

Change #1153343 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] user: Remove hard-deprecated User::whoIs/whoIsReal

https://gerrit.wikimedia.org/r/1153343