Page MenuHomePhabricator
Create Task
Maniphest T281492

Add partial action block tests to PermissionManagerTest [S]
Closed, ResolvedPublic
Actions

Description

We could add some cases to PermissionManagerTest::testCheckUserBlockActions that contain blocks against certain actions.

This will be easier to do after T279559, which introduces the method BlockActionInfo::getActionFromId.

Details

SubjectRepoBranchLines +/-
Add partial action block tests to PermissionManagerTestmediawiki/coremaster+20 -0
Customize query in gerrit

Related Objects

Event Timeline

Tchanders created this task.Apr 29 2021, 3:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 29 2021, 3:09 PM
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.May 12 2021, 3:56 PM
ARamirez_WMF renamed this task from Add partial action block tests to PermissionManagerTest to Add partial action block tests to PermissionManagerTest [S].May 12 2021, 4:08 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.
Niharika moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.May 13 2021, 1:57 PM
Niharika edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
STran claimed this task.May 25 2021, 4:16 PM
STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
Tchanders updated the task description. (Show Details)May 26 2021, 5:25 PM
gerritbot added a comment.Jun 2 2021, 12:53 PM

Change 697783 had a related patch set uploaded (by STran; author: STran):

[mediawiki/core@master] Add partial action block tests to PermissionManagerTest

https://gerrit.wikimedia.org/r/697783

gerritbot added a project: Patch-For-Review.Jun 2 2021, 12:53 PM
• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jun 2 2021, 1:52 PM
• TThoabala moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Jun 2 2021, 3:09 PM
gerritbot added a comment.Jun 3 2021, 5:59 PM

Change 697783 merged by jenkins-bot:

[mediawiki/core@master] Add partial action block tests to PermissionManagerTest

https://gerrit.wikimedia.org/r/697783

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 3 2021, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 3 2021, 6:10 PM
STran moved this task from Code Review 🔍 to Done: Q4 (2020-21) on the Anti-Harassment (The Letter Song) board.Jun 7 2021, 6:07 PM
Niharika closed this task as Resolved.Jun 8 2021, 4:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits