Page MenuHomePhabricator

extensions/AccessControl - Use UserGroupManager instead of User group methods
Open, MediumPublic

Description

Find all usages of:

  • public function getGroups()
  • public function getGroupMemberships()
  • public function getEffectiveGroups()
  • public function getAutomaticGroups()
  • public function getFormerGroups()
  • public function addGroup()
  • public function removeGroup()
  • public function addAutopromoteOnceGroups())

and need to be replaced with corresponding UserGroupManager methods.
You can obtain UserGroupManager via MediaWikiServices::getInstance()->getUserGroupManager(), but it's preferred to inject it if possible.

Event Timeline

Vlad.shapik triaged this task as Medium priority.May 4 2021, 1:17 PM
Vlad.shapik created this task.
Vlad.shapik renamed this task from extensions/AccessControl - hard deprecate User group methods to extensions/AccessControl - Use UserGroupManager instead of User group methods.May 6 2021, 2:38 PM
This comment was removed by Vlad.shapik.

Change 700662 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/AccessControl@master] Avoid using User::getGroups

https://gerrit.wikimedia.org/r/700662

Change 700662 merged by jenkins-bot:

[mediawiki/extensions/AccessControl@master] Avoid using User::getGroups

https://gerrit.wikimedia.org/r/700662