Maniphest T282067

TypeError: Cannot read property 'top' of undefined / TypeError: $revisionWrapper.offset() is undefined
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

144 errors in last 12hrs.
Example: https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.05.05?id=WDmvPnkBfVMx58vqqzUS
Board: https://logstash.wikimedia.org/goto/ed115437c17d13db4713c7ec10d0c95b

at setRevisionHovered URL1:20:9
at showTooltipsOnMouseMoveHandler URL1:46:1001
at URL1:44:648
at dispatch URL2:70:219

URL1: https://ja.wikipedia.org/w/load.php?lang=ja&modules=ext.RevisionSlider.HelpDialog%2CPointer%2CRevisionList%2CSlider%2CdialogImages%2Cinit%7Cjquery.ui%7Coojs-ui.styles.icons-moderation&skin=vector&version=16ps2
URL2: https://ja.wikipedia.org/w/load.php?lang=ja&modules=jquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=1dspt

Details

	Subject	Repo	Branch	Lines +/-
	Fix jQuery.offset() calculation possibly failing	mediawiki/extensions/RevisionSlider	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: Blog Post: Production Excellence #32: May 2021
Mentioned Here: T285893: TypeError: Cannot read property 'top' of undefined

Event Timeline

Jdlrobson created this task.May 5 2021, 11:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2021, 11:12 PM

Krinkle moved this task from Untriaged to May 2021 on the Wikimedia-production-error board.May 12 2021, 6:32 PM

Krinkle added a project: WMDE-TechWish.

Krinkle mentioned this in Blog Post: Production Excellence #32: May 2021.Jun 21 2021, 1:31 AM

Change 700609 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/RevisionSlider@master] Fix jQuery.offset() calculation possibly failing

https://gerrit.wikimedia.org/r/700609

gerritbot added a project: Patch-For-Review.Jun 21 2021, 1:35 PM

Change 700609 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Fix jQuery.offset() calculation possibly failing

https://gerrit.wikimedia.org/r/700609

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 21 2021, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 21 2021, 8:10 PM

No errors in the last 12hrs! yay! Thanks @thiemowmde and @WMDE-Fisch !

thiemowmde claimed this task.Jun 28 2021, 7:22 AM

thiemowmde edited projects, added WMDE-TechWish-Sprint-2021-06-09, Unplanned-Sprint-Work; removed WMDE-TechWish.

thiemowmde set the point value for this task to 1.

WMDE-Fisch moved this task from Sprint Backlog to Done on the WMDE-TechWish-Sprint-2021-06-09 board.Jun 29 2021, 1:06 PM

There's a new variant of this now (less frequent):

at SliderView.pointerContainerClickHandler  https://ru.wikipedia.org/w/load.php?lang=ru&modules=ext.RevisionSlider.HelpDialog%2CPointer%2CRevisionList%2CSlider%2CdialogImages%2Cinit%7Cjquery.ui%7Cmoment&skin=vector&version=1e4cb:48:303
at HTMLDivElement.<anonymous>  https://ru.wikipedia.org/w/load.php?lang=ru&modules=ext.RevisionSlider.HelpDialog%2CPointer%2CRevisionList%2CSlider%2CdialogImages%2Cinit%7Cjquery.ui%7Cmoment&skin=vector&version=1e4cb:45:276
at HTMLDivElement.dispatch  https://ru.wikipedia.org/w/load.php?lang=ru&modules=ext.RevisionSlider.Settings%2ClazyJs%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=1nrha:71:214
at HTMLDivElement.elemData.handle  https://ru.wikipedia.org/w/load.php?lang=ru&modules=ext.RevisionSlider.Settings%2ClazyJs%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=vector&version=1nrha:67:848

Thanks. I think this it something more serious because it's in a code path that's critical for the functionality of the extension. Are you able to open a new ticket for this?

Opened T285893

TypeError: Cannot read property 'top' of undefined / TypeError: $revisionWrapper.offset() is undefined Closed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

TypeError: Cannot read property 'top' of undefined / TypeError: $revisionWrapper.offset() is undefined
Closed, ResolvedPublic1 Estimated Story Points
Actions