Are you sure it belongs to UploadWizard? It happens in the normal Special:Upload

neilk wrote:

(In reply to comment #0)

On trunk version, uploading a duplicate with a different name, pressing either
wpUpload or wpUploadIgnoreWarning seem to cancel it.
Back to Special:Upload in both cases, no edit to the original page.

I don't understand this report, and it doesn't seem to apply to UploadWizard...

UploadWizard doesn't handle the duplicate case properly yet but you seem to be talking about something else.

Bryan.TongMinh wrote:

I'm sorry, somehow I read it as "wpUploadIgnoreWizard" or something :)

Bryan.TongMinh wrote:

I think this is the same bug as bug 26929. Platonides, can you confirm?

Bug 26929 is about the text being wrong. This is a functionality bug about buttons which do nothing. It's still present in current trunk.

Steps to reproduce:
0- Have an uploaded file A with name A
1- Go to Special:Upload
2- Choose to the same source file but place a different name (B).
3- Press upload
You are sent to an intermediate page (this file is already uploaded with a different name), with three buttons:

• wpUpload is supposed to perform an edit in the description page ([[File:A]])
• wpUploadIgnoreWarning is supposed to upload the duplicate with name B, just as if the "Ignore warnings" checkbox had been checked.
• wpCancelUpload sends you back to Special:Upload

The three of them send you back to Special:Upload. The labeled actions are not even done in the background.

This bug was filled pre-branch, marking as blocker for 1.17.

Bryan.TongMinh wrote:

Sigh... I don't know what it is with this bug report, but I keep on misreading stuff...

I meant bug 27021, and from your description this is definitely the same bug.

*** This bug has been marked as a duplicate of bug 27021 ***

Heh, that other bug makes more sense :)

r81197 only fixed the wpUploadIgnoreWarning button (which was the only issue reported in bug 27021).

Reopening for wpUpload

Bryan.TongMinh wrote:

(In reply to comment #7)

Heh, that other bug makes more sense :)

r81197 only fixed the wpUploadIgnoreWarning button (which was the only issue
reported in bug 27021).

Reopening for wpUpload

Clicking wpUpload gives you again the warning, which is more or less the intention. Or are you refering to another behaviour?
A dupe warning can only be overriden by clicking wpUploadWarning. This is perhaps not very intuitive. In any case this behaviour was already present in 1.16, so should not be a blocker.

That wpUpload uses label upload-tryagain ('Submit modified file description'). It seems intended to add a new text revision to the description page of the existing file.

Bryan.TongMinh wrote:

The bug is the label text, it may be interpreted in different ways, and the way you are interpreting it (and most others probably would) is not what it is supposed to do.

How should it be interpreted?
Changing the description page seemed sensible, given that some people reupload files with a different summary trying to modify the description.

Not a blocker. Looks like it was there in 1.16.