| Srdjan | |
| May 8 2021, 6:25 PM |
| F34551065: Screen Shot 2021-07-14 at 9.20.01 AM.png | |
| Jul 14 2021, 4:22 PM |
| F34488449: Screen Shot 2021-06-09 at 9.08.36 AM.png | |
| Jun 9 2021, 4:09 PM |
| F34470405: image.png | |
| May 26 2021, 10:00 PM |
| F34470398: Screen Shot 2021-05-26 at 2.53.51 PM.png | |
| May 26 2021, 9:54 PM |
| F34470154: image.png | |
| May 26 2021, 7:43 PM |
| F34446703: Screen Shot 2021-05-09 at 19.18.51.png | |
| May 8 2021, 6:25 PM |
| F34446699: Screen Shot 2021-05-09 at 19.19.09.png | |
| May 8 2021, 6:25 PM |
I'm pretty sure the extra space started appearing after the new interlanguage selector was deployed. Safari seems unaffected.
| AC | Status | Details |
|---|---|---|
| 1 | ✅ | T282318#7212677 |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove whitespace from page title template | mediawiki/skins/Vector | master | +1 -3 |
Can reproduce, but code doesn't provide a clear hint at the moment. Even when display:noneing all other elements in header space remains.
The issue is the #contentSub and #contentSub2 element styling rules in core/resources/src/mediawiki.skinning/interface.less. Those have margins that should likely not apply when their elements are empty.
@Jdlrobson No, that's not the cause. It's something weirder.
This task is about this space, presumably not a margin.
ahhh okay thanks for the sharing understanding. That's just whitespace
<h1 id="firstHeading" class="firstHeading" {{{html-user-language-attributes}}}>
{{{html-title}}}
</h1>should become
<h1 id="firstHeading" class="firstHeading" {{{html-user-language-attributes}}}>
{{{html-title}}}{{!
}}</h1>I can confirm this is the text with the problem
Once that's trimmed, we're all good here, so solution is hopefully pretty straightforward.
Change 701431 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Remove whitespace from page title template
Change 701431 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Remove whitespace from page title template
Status: ✅ PASS
Environment: enwiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA
Test Artifact(s):
Enable new Vector and visit the following page in Firefox (I'm using 88.0.1 on macOS 10.15.7): https://en.wikipedia.org/wiki/Mark_Selby
Attempt to select the title text as if you're copying it.
✅ AC1: There should be no white space at the end of the title.
