Page MenuHomePhabricator
Create Task
Maniphest T282720

GrowthExperiments / SuggestedEditsTest: Call to undefined method Mock_PageViewService_963a7339::supports()
Closed, ResolvedPublic
Actions

Description

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/689938
https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/54121/console

19:00:41 1) GrowthExperiments\Tests\HomepageModules\SuggestedEditsTest::testNoTopicFiltersWhenTopicMatchingDisabled
19:00:41 Error: Call to undefined method Mock_PageViewService_963a7339::supports()
19:00:41 
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:701
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:418
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:156
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:137
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:264
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:97
19:00:41 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/HomepageModules/SuggestedEditsTest.php:42
19:00:41 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108

Details

SubjectRepoBranchLines +/-
Skip SuggestedEditsTest when PageViewInfo is not installedmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.5+3 -0
Skip SuggestedEditsTest when PageViewInfo is not installedmediawiki/extensions/GrowthExperimentswmf/1.37.0-wmf.4+3 -0
Zuul: Add PageViewInfo and Graph to gated extensionsintegration/configmaster+4 -0
Remove GrowthExperiments from gated extensionsintegration/configmaster+0 -2
Skip SuggestedEditsTest when PageViewInfo is not installedmediawiki/extensions/GrowthExperimentsmaster+3 -0
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.May 12 2021, 6:11 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 12 2021, 6:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr triaged this task as Unbreak Now! priority.May 12 2021, 6:11 PM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Tgr moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 12 2021, 6:13 PM

Change 689892 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] Remove GrowthExperiments from gated extensions

https://gerrit.wikimedia.org/r/689892

gerritbot added a project: Patch-For-Review.May 12 2021, 6:13 PM

Change 690004 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] Zuul: Add PageViewInfo to gated extensions

https://gerrit.wikimedia.org/r/690004

gerritbot added a comment.May 12 2021, 6:29 PM

Change 690007 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/690007

kostajh edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error.May 12 2021, 6:29 PM
gerritbot added a comment.May 12 2021, 6:38 PM

Change 689893 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.4] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/689893

gerritbot added a comment.May 12 2021, 6:38 PM

Change 689894 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/689894

gerritbot added a comment.May 12 2021, 7:01 PM

Change 690007 merged by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@master] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/690007

Tgr added a comment.May 12 2021, 7:03 PM

I think this is fixed, but now we have T282731: Wikibase\...: TypeError: Argument 1 passed to GrowthExperiments\...\LinkRecommendationStore::__construct() must implement interface ...\IDatabase, null given.

gerritbot added a comment.May 12 2021, 7:26 PM

Change 690004 abandoned by Kosta Harlan:

[integration/config@master] Zuul: Add PageViewInfo to gated extensions

Reason:

https://gerrit.wikimedia.org/r/690004

gerritbot added a comment.May 12 2021, 7:27 PM

Change 689892 abandoned by Kosta Harlan:

[integration/config@master] Remove GrowthExperiments from gated extensions

Reason:

I2ff5ad99a40 and I96e07e1094 are alternatives that should fix the breakage.

https://gerrit.wikimedia.org/r/689892

gerritbot added a comment.May 12 2021, 7:27 PM

Change 690004 restored by Jforrester:

[integration/config@master] Zuul: Add PageViewInfo to gated extensions

https://gerrit.wikimedia.org/r/690004

gerritbot added a comment.May 12 2021, 7:30 PM

Change 690004 merged by jenkins-bot:

[integration/config@master] Zuul: Add PageViewInfo and Graph to gated extensions

https://gerrit.wikimedia.org/r/690004

gerritbot added a comment.May 12 2021, 8:39 PM

Change 689893 merged by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.4] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/689893

gerritbot added a comment.May 12 2021, 8:39 PM

Change 689894 merged by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/689894

DannyS712 subscribed.May 12 2021, 9:07 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 12 2021, 9:23 PM
Tgr closed this task as Resolved.May 13 2021, 12:08 AM
Tgr claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL