Page MenuHomePhabricator

GrowthExperiments / SuggestedEditsTest: Call to undefined method Mock_PageViewService_963a7339::supports()
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/c/mediawiki/core/+/689938
https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/54121/console

19:00:41 1) GrowthExperiments\Tests\HomepageModules\SuggestedEditsTest::testNoTopicFiltersWhenTopicMatchingDisabled
19:00:41 Error: Call to undefined method Mock_PageViewService_963a7339::supports()
19:00:41 
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:701
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:418
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:156
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:137
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/SuggestedEdits.php:264
19:00:41 /workspace/src/extensions/GrowthExperiments/includes/HomepageModules/BaseModule.php:97
19:00:41 /workspace/src/extensions/GrowthExperiments/tests/phpunit/unit/HomepageModules/SuggestedEditsTest.php:42
19:00:41 /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php:108

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr triaged this task as Unbreak Now! priority.May 12 2021, 6:11 PM
Tgr edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Tgr moved this task from Incoming to In Progress on the Growth-Team (Current Sprint) board.

Change 689892 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] Remove GrowthExperiments from gated extensions

https://gerrit.wikimedia.org/r/689892

Change 690004 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] Zuul: Add PageViewInfo to gated extensions

https://gerrit.wikimedia.org/r/690004

Change 690007 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/690007

Change 689893 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.4] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/689893

Change 689894 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/689894

Change 690007 merged by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@master] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/690007

Change 690004 abandoned by Kosta Harlan:

[integration/config@master] Zuul: Add PageViewInfo to gated extensions

Reason:

https://gerrit.wikimedia.org/r/690004

Change 689892 abandoned by Kosta Harlan:

[integration/config@master] Remove GrowthExperiments from gated extensions

Reason:

I2ff5ad99a40 and I96e07e1094 are alternatives that should fix the breakage.

https://gerrit.wikimedia.org/r/689892

Change 690004 restored by Jforrester:

[integration/config@master] Zuul: Add PageViewInfo to gated extensions

https://gerrit.wikimedia.org/r/690004

Change 690004 merged by jenkins-bot:

[integration/config@master] Zuul: Add PageViewInfo and Graph to gated extensions

https://gerrit.wikimedia.org/r/690004

Change 689893 merged by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.4] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/689893

Change 689894 merged by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.5] Skip SuggestedEditsTest when PageViewInfo is not installed

https://gerrit.wikimedia.org/r/689894

Tgr claimed this task.