Page MenuHomePhabricator

Replace LBFactory with injecting new Db-Service in Client's ChangeModificationNotificationJob and child-classes
Closed, ResolvedPublic

Description

The abstract class ChangeModificationNotificationJob has two concrete implementations, ChangeDeletionNotificationJob and ChangeVisibilityNotificationJob. All three of them use LBFactory in some way.

ChangeModificationNotificationJob uses it with

$this->lbFactory->getMainLB()->getConnection( DB_REPLICA );

and the two concrete implementation use it with

$dbw = $this->lbFactory->getMainLB()->getConnection( DB_MASTER );

and

$this->lbFactory->waitForReplication();

(We maybe could use this opportunity to replace the deprecated constant DB_MASTER with DB_PRIMARY.)

Event Timeline

Change 696463 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/Wikibase@master] Add ClientDomainDb and use it in Change Notification Jobs

https://gerrit.wikimedia.org/r/696463

Change 696463 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add ClientDomainDb and use it in Change Notification Jobs

https://gerrit.wikimedia.org/r/696463

Michael claimed this task.

This is done with the merged patch, I think.