Page MenuHomePhabricator
Create Task
Maniphest T283812

Move destructive close icon from OOUI to GrowthExperiments
Closed, ResolvedPublic
Actions

Description

Per follow-up on https://gerrit.wikimedia.org/r/c/oojs/ui/+/681941, it's potentially misleading and should not be available centrally.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.42.1mediawiki/coremaster+281 -212
icons: Mark 'destructive' variant of close icon as deprecatedoojs/uimaster+2 -1
AddLink: Move close destructive variant into extensionmediawiki/extensions/GrowthExperimentsmaster+11 -1
Customize query in gerrit

Event Timeline

Tgr created this task.May 27 2021, 1:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 27 2021, 1:03 PM
Tgr triaged this task as Medium priority.Jun 1 2021, 9:33 PM
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh claimed this task.Aug 19 2021, 2:26 PM
kostajh moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Aug 19 2021, 2:27 PM

Change 713881 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: Move close destructive variant into extension

https://gerrit.wikimedia.org/r/713881

gerritbot added a project: Patch-For-Review.Aug 19 2021, 2:27 PM
kostajh moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 19 2021, 2:27 PM
• mewoph moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 19 2021, 3:41 PM
gerritbot added a comment.Aug 19 2021, 3:59 PM

Change 713881 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: Move close destructive variant into extension

https://gerrit.wikimedia.org/r/713881

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 19 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 19 2021, 4:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Aug 19 2021, 9:44 PM
Etonkovidova subscribed.

Checked on betalabs

wmf.19betalabs
Screen Shot 2021-08-19 at 2.42.26 PM.png (934×1 px, 195 KB)
Screen Shot 2021-08-19 at 2.42.59 PM.png (482×501 px, 59 KB)
gerritbot added a comment.Aug 23 2021, 9:39 AM

Change 714332 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[oojs/ui@master] Mark 'destructive' variant of close icon as deprecated

https://gerrit.wikimedia.org/r/714332

gerritbot added a project: Patch-For-Review.Aug 23 2021, 9:39 AM
Etonkovidova closed this task as Resolved.Aug 24 2021, 11:14 PM
gerritbot added a comment.Sep 11 2021, 5:38 AM

Change 714332 merged by jenkins-bot:

[oojs/ui@master] icons: Mark 'destructive' variant of close icon as deprecated

https://gerrit.wikimedia.org/r/714332

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2021, 6:10 AM
gerritbot added a comment.Nov 4 2021, 2:10 AM

Change 736621 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update OOUI to v0.42.1

https://gerrit.wikimedia.org/r/736621

gerritbot added a project: Patch-For-Review.Nov 4 2021, 2:10 AM
gerritbot added a comment.Nov 4 2021, 9:16 PM

Change 736621 merged by jenkins-bot:

[mediawiki/core@master] Update OOUI to v0.42.1

https://gerrit.wikimedia.org/r/736621

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits