Page MenuHomePhabricator

[L] Enable changes to MediaSearch tab order
Closed, ResolvedPublic

Description

As an administrator of a non-Commons Wiki, if I were going to implement MediaSearch, I may want to change the order of the tabs from the default on Commons, since images may not be the most important type of information being searched on my Wiki.

Currently the order is defined in SpecialMediaSearch.php. There are probably a couple of ways of approaching this but changing the order seems fairly doable.

Acceptance Criteria:

  • Determine best approach to changing the tab order and document reasons that's the best approach
  • Making tab order configurable in MediaSearch extension
  • The tab order will be configured via config, falling back to current tab order
  • Implement ability to include or remove tabs

Event Timeline

Seddon renamed this task from Enable changes to MediaWiki tab order to Enable changes to MediaSearch tab order.Jun 3 2021, 9:13 AM
CBogen renamed this task from Enable changes to MediaSearch tab order to [L] Enable changes to MediaSearch tab order.Aug 17 2021, 4:52 PM
CBogen updated the task description. (Show Details)

Change 727019 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/MediaSearch@master] WIP Enable Changes to MS tab order

https://gerrit.wikimedia.org/r/727019

		$wgMediaSearchSetTabOrder = true;
		$wgMediaSearchTabOrder = [ 'page','image','audio','video','other' ];

Change 738293 had a related patch set uploaded (by Seddon; author: Seddon):

[operations/mediawiki-config@master] Enable changes to mediasearch tab order

https://gerrit.wikimedia.org/r/738293

Change 738293 abandoned by Cparle:

[operations/mediawiki-config@master] Enable changes to mediasearch tab order

Reason:

https://gerrit.wikimedia.org/r/738293

Change 727019 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Enable Changes to MS tab order

https://gerrit.wikimedia.org/r/727019

Change 753429 had a related patch set uploaded (by Cparle; author: Cparle):

[operations/mediawiki-config@master] Modify mediasearch tab order on beta commons for testing

https://gerrit.wikimedia.org/r/753429

Change 753429 merged by jenkins-bot:

[operations/mediawiki-config@master] Modify mediasearch tab order on beta commons for testing

https://gerrit.wikimedia.org/r/753429

To allow testing I've set the config for beta so that the video and audio tabs are switched around

Change 753433 had a related patch set uploaded (by Cparle; author: Cparle):

[operations/mediawiki-config@master] Switch audio and video mediasearch tabs for testing

https://gerrit.wikimedia.org/r/753433

Change 753433 merged by jenkins-bot:

[operations/mediawiki-config@master] Switch audio and video mediasearch tabs for testing

https://gerrit.wikimedia.org/r/753433

Etonkovidova subscribed.

To allow testing I've set the config for beta so that the video and audio tabs are switched around

Testing is done on betalabs, thanks, @Cparle!

Moving to Verify on Production for regression testing only.