External Link icons not shown on MediaWiki 1.36.0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lakejason0
	Jun 6 2021, 12:23 PM

Description

I found that since my site upgraded to 1.36.0, all the external links are no longer with a external link icon beside them. Then I opened my devtools and found this:

A double slash instead of the expected single slash is in the url. I doubted with my local settings so I posted on the MediaWiki Discord but it seems fine:

Please notice that my $wgScriptPath is "". I found wmf hosted wikis are fine but their script path is with "w/".
Only external link icons, as well as ftp mailto etc. icons, are affected. Other images under resource is fine, e.g. the Powered by MediaWiki icon, the license icon.
For skins that overrides the links icon written in mediawiki.skinning.content.externallinks (e.g. Vector), the icons are still there. So probably it's not related to a single skin.

Details

	Subject	Repo	Branch	Lines +/-
	resourceloader: Fix remote base path at document root passed into SkinModule	mediawiki/core	REL1_36	+37 -5
	resourceloader: Fix remote bash path at document root passed into SkinModule	mediawiki/core	master	+35 -5

Customize query in gerrit

Related Objects

Mentioned Here: T282280: CSS background with root-relative URL causes exception in css minifier for wikis using the document root as its script path
rMWe2a91921c5bd: resourceloader: Fix FileModule resource URLs for document root wikis

Event Timeline

Lakejason0 created this task.Jun 6 2021, 12:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 6 2021, 12:23 PM

Lakejason0 added a project: MediaWiki-User-Interface.Jun 6 2021, 12:25 PM

Lakejason0 updated the task description. (Show Details)Jun 6 2021, 12:29 PM

Ciencia_Al_Poder subscribed.Jun 6 2021, 1:01 PM

Izno subscribed.Jun 6 2021, 2:20 PM

Reproducible for me as well. Similar to T282280 but that patch doesn't cause nor fixes it (I've tried reversing it with no changes)

It may be related to: rMWe2a91921c5bd951873a524ed9c085408881d4363

Restricted Application added a project: Performance-Team. · View Herald TranscriptJun 6 2021, 4:52 PM

Krinkle triaged this task as High priority.Jun 7 2021, 6:39 PM

• Gilles assigned this task to Krinkle.Jun 7 2021, 6:39 PM

• Gilles moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.

Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.Jun 7 2021, 6:44 PM

On a non-root wiki, steps to reproduce:

Find equivalent of http://default.web.mw.localhost:8080/mediawiki/load.php?lang=en&modules=skins.vector.styles.legacy&only=styles&skin=vector&debug=true and open it.
Set $wgScriptPath = ""; in LocalSettings.php.
Refresh.

The resulting output contains:

/* Good */
  background-image: url(/skins/Vector/resources/common/images/user-avatar.svg?b7f58);
/* Good */
  .mw-wiki-logo { background-image: url(/resources/assets/wiki.png?4d48b); }
/* Bad */
  background-image: url(//resources/src/mediawiki.skinning/images/magnify-clip-ltr.png?4f704);

In SkinModule::getStyleFiles, the FilePath values are as follows:

"screen": [
    {
        "filepath": "resources/src/mediawiki.skinning/content.thumbnails.less",
        "local": "/var/www/mediawiki",
        "remote": "/"
    },

That seems okay. The remote here is set as $defaultRemoteBasePath which comes from ResourceLoaderFileModule::extractBasePaths( .., ResourceBasePath) which correctly turns '' into '/'.

Later on, in FileModule::processStyle() when it is time to call CSSMin for remapping, we observe that the input has already been damanged by this point:

{
    "$localPath": "/var/www/mediawiki/resources/src/mediawiki.skinning/content.thumbnails.less",
    "$remotePath": "//resources/src/mediawiki.skinning/content.thumbnails.less"
}
{
    "$localDir": "/var/www/mediawiki/resources/src/mediawiki.skinning",
    "$remoteDir": "//resources/src/mediawiki.skinning"
}

Backing up from there, we see it works fine for skin and extension file paths:

ResourceLoaderFileModule::getRemotePath: $path arg = <string> = resources/common/common.less
{
    "$localPath": "/var/www/mediawiki/skins/Vector/resources/common/common.less",
    "$remotePath": "/skins/Vector/resources/common/common.less"
}
{
    "$localDir": "/var/www/mediawiki/skins/Vector/resources/common",
    "$remoteDir": "/skins/Vector/resources/common"
}

But goes wrong for core paths from SkinModule:

ResourceLoaderFileModule::getRemotePath: $path arg = <ResourceLoaderFilePath>remotePath = //resources/src/mediawiki.skinning/content.thumbnails.less
{
    "$localPath": "/var/www/mediawiki/resources/src/mediawiki.skinning/content.thumbnails.less",
    "$remotePath": "//resources/src/mediawiki.skinning/content.thumbnails.less"
}
{
    "$localDir": "/var/www/mediawiki/resources/src/mediawiki.skinning",
    "$remoteDir": "//resources/src/mediawiki.skinning"
}

The problem seems to be that FilePath::getRemotePath() inserts a slash if the remote base is a non-empty string, which is expected to not have a trailing slash. And this expectation is violated by SkinModule which passes it the already processed value from extractBasePaths() where such root paths are no longer empty strings.