Page MenuHomePhabricator

Add EmbedVideo (fork) to translatewiki.net
Closed, ResolvedPublic

Description

Project information

Name: EmbedVideo
Code repository: https://github.com/StarCitizenWiki/mediawiki-extensions-EmbedVideo

OS License: MIT
Issue Tracker: https://github.com/StarCitizenWiki/mediawiki-extensions-EmbedVideo/issues
Project contact: Octfx

Project description:
Ongoing fork of https://www.mediawiki.org/wiki/Extension:EmbedVideo

NOTE: Section below will be filled by twn staff

Project setup checklist

Project configuration (for translation admins)

Namespace: NS_MEDIAWIKI
Prefix: mwgithub-star-citizen-embedvideo
Validators:

  1. MediaWikiParameter
  2. BraceBalance

Optional message definitions:

  1. embedvideo-video-short-desc
  2. embedvideo-audio-short-desc

Concerns

  1. Contents of qqq.json are identical to the contents of en.json. If there is nothing additional to add, these can be removed. An example: qqq.json file.

Event Timeline

abi_ triaged this task as Medium priority.
abi_ updated the task description. (Show Details)

@Octfx - couple of things:

  1. Contents of qqq.json are identical to the contents of en.json. If there is nothing additional to add, these can be removed. An example: qqq.json file.
  2. Can we use the embedvideo prefix for all strings (other than apihelp) defined here? https://github.com/StarCitizenTools/mediawiki-extensions-EmbedVideo/blob/master/i18n/en.json#L6? Currently the messages starting with error don't have this prefix, and there are some messages with the prefix ev_

Sure!
I've updated the current develop branch (and changed the source branch to develop also)

Change 699403 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Add support for EmbedVideo extension

https://gerrit.wikimedia.org/r/699403

Sure!
I've updated the current develop branch (and changed the source branch to develop also)

  1. Sorry, I did not notice this earlier. but can we use hyphen's (-) instead of underscsore (_) for all message keys, just to be consistent? embedvideo_audio_short_desc --> `embedvideo-audio-short-desc
  2. Can you update the description here to mention that this is a fork?

Sure!
I've updated the current develop branch (and changed the source branch to develop also)

  1. Sorry, I did not notice this earlier. but can we use hyphen's (-) instead of underscsore (_) for all message keys, just to be consistent? embedvideo_audio_short_desc --> `embedvideo-audio-short-desc
  2. Can you update the description here to mention that this is a fork?

I've update the message files

@Octfx - I still see messages using _. Can we stick to using - everywhere? Eg: embedvideo_video_short_desc, embedvideo_audio_long_desc, embedvideo_video_long_desc etc

@Octfx - I still see messages using _. Can we stick to using - everywhere? Eg: embedvideo_video_short_desc, embedvideo_audio_long_desc, embedvideo_video_long_desc etc

Did you check the develop branch? Master isn't updated yet as there are some things missing for the next release.

@Octfx - I still see messages using _. Can we stick to using - everywhere? Eg: embedvideo_video_short_desc, embedvideo_audio_long_desc, embedvideo_video_long_desc etc

Did you check the develop branch? Master isn't updated yet as there are some things missing for the next release.

I was checking the develop branch. See screenshot below:

image.png (957×1 px, 181 KB)

My previous comment also includes a link.

Ah sorry, I missed that!
Message keys should be fixed now :)

Change 699403 merged by jenkins-bot:

[translatewiki@master] Add support for EmbedVideo extension

https://gerrit.wikimedia.org/r/699403

Change 700185 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] EmbedVideo: Fix repo URL

https://gerrit.wikimedia.org/r/700185

Change 700185 merged by jenkins-bot:

[translatewiki@master] EmbedVideo: Fix repo URL

https://gerrit.wikimedia.org/r/700185