Page MenuHomePhabricator

Librarize NormalizedException patch
Closed, ResolvedPublic

Description

Per feedback received on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/670465, turn it into a library so it can be used by other libraries like Assert.

Event Timeline

Change 700089 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/libs/NormalizedException@master] Initial commit

https://gerrit.wikimedia.org/r/700089

Change 700090 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/libs/NormalizedException@master] Add CI and other boilerplate

https://gerrit.wikimedia.org/r/700090

Change 700092 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[integration/config@master] Add NormalizedException PHP library to CI

https://gerrit.wikimedia.org/r/700092

Change 700092 merged by jenkins-bot:

[integration/config@master] Zuul: Install CI for mediawiki/libs/NormalizedException

https://gerrit.wikimedia.org/r/700092

Mentioned in SAL (#wikimedia-releng) [2021-06-16T21:47:00Z] <James_F> Zuul: Install CI for mediawiki/libs/NormalizedException T284732

Change 700089 merged by Ppchelko:

[mediawiki/libs/NormalizedException@master] Initial commit

https://gerrit.wikimedia.org/r/700089

Change 700090 merged by jenkins-bot:

[mediawiki/libs/NormalizedException@master] Add CI and other boilerplate

https://gerrit.wikimedia.org/r/700090

https://integration.wikimedia.org/ci/job/phpunit-coverage-php72-docker-publish/1133/console fails with

01:33:48 PHPUnit 8.5.17 by Sebastian Bergmann and contributors.
01:33:48 
01:33:48   Warning - The configuration file did not pass validation!
01:33:48   The following problems have been detected:
01:33:48 
01:33:48   Line 9:
01:33:48   - Element 'coverage': This element is not expected.
01:33:48 
01:33:48   Test results may not be as expected.
01:33:48 
01:33:48 
01:33:48 Error:         Incorrect whitelist config, no code coverage will be generated.
01:33:48 
01:33:48 ..............                                                    14 / 14 (100%)
01:33:48 
01:33:48 Time: 50 ms, Memory: 6.00 MB
Krinkle subscribed.

Remember to add the library to https://www.mediawiki.org/wiki/Developers/Maintainers and document which where issues should be filed, and who will triage and work on such issues. (Also consider adding to a Herald rule to simplify discovery.)

Added, thanks for the warning @Krinkle!

What would the Herald rule do? Add NormalizedException to tasks with the NormalizedException word in them? The library provides a NormalizedException class which might get used in MediaWiki components and thus show up in stack traces, so I'm not sure that would work well.