Page MenuHomePhabricator
Create Task
Maniphest T284758

Keyboard shortcut help in reply tool shows commands which aren't available
Closed, ResolvedPublic
Actions

Description

  1. Open reply tool in visual mode
  2. Press Ctrl+?
  3. Observe "CTRL+1-6 Heading (1-6)" is listed as a shortcut, also "Type {{ Template" and various other things which are disabled in the reply tool

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (6c7bee041)mediawiki/extensions/VisualEditormaster+1 -1
Unregister sequence help for unavailable commandsmediawiki/extensions/DiscussionToolsmaster+7 -0
Help dialog: Hide commands which are not in surface.getCommands()VisualEditor/VisualEditormaster+20 -3
Customize query in gerrit

Event Timeline

Esanders created this task.Jun 10 2021, 3:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 10 2021, 3:37 PM
gerritbot added a comment.Jun 10 2021, 3:38 PM

Change 698881 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Help dialog: Hide commands which are not in surface.getCommands()

https://gerrit.wikimedia.org/r/698881

gerritbot added a project: Patch-For-Review.Jun 10 2021, 3:38 PM
Esanders claimed this task.Jun 10 2021, 3:38 PM
Esanders added a project: Editing-team (Kanban Board).
Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jun 17 2021, 12:57 PM

Change 698881 had a related patch set uploaded (by Bartosz Dziewoński; author: Esanders):

[VisualEditor/VisualEditor@master] Help dialog: Hide commands which are not in surface.getCommands()

https://gerrit.wikimedia.org/r/698881

gerritbot added a comment.Jun 17 2021, 1:04 PM

Change 698881 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Help dialog: Hide commands which are not in surface.getCommands()

https://gerrit.wikimedia.org/r/698881

matmarex subscribed.Jun 17 2021, 1:14 PM

It was noted in code review that the patch does not completely fix this issue:

@matmarex

Doesn't seem to fix the issues you described in the task. (…) E.g. "Type {{" is still in the dialog. (…)

@Esanders

The {{ stuff is registered as a wikitextWarning, that will need to be fixed separately.

BeforeAfter
image.png (2×3 px, 601 KB)
image.png (2×3 px, 595 KB)
matmarex moved this task from Code Review to Blocked / Needs More Work on the Editing-team (Kanban Board) board.Jun 17 2021, 1:14 PM
gerritbot added a comment.Jun 17 2021, 8:31 PM

Change 700247 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/DiscussionTools@master] Unregister sequence help for unavailable commands

https://gerrit.wikimedia.org/r/700247

gerritbot added a comment.Jun 19 2021, 1:59 PM

Change 700427 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c7bee041)

https://gerrit.wikimedia.org/r/700427

gerritbot added a comment.Jun 19 2021, 2:01 PM

Change 700247 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Unregister sequence help for unavailable commands

https://gerrit.wikimedia.org/r/700247

matmarex moved this task from Blocked / Needs More Work to QA on the Editing-team (Kanban Board) board.Jun 19 2021, 2:02 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.

Should be good now with the second patch.

gerritbot added a comment.Jun 19 2021, 2:17 PM

Change 700427 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (6c7bee041)

https://gerrit.wikimedia.org/r/700427

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.11; 2021-06-21).Jun 19 2021, 3:00 PM
matmarex moved this task from Backlog to Triaged on the DiscussionTools board.Jul 1 2021, 2:56 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jul 1 2021, 11:28 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
• ppelberg closed this task as Resolved.Jul 3 2021, 1:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL