WikiEditor toolbar overlaps Wikisource onboarding popup
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Samwilson
	Jun 24 2021, 7:10 AM

Description

MediaWiki-extensions-CodeMirror is setting the z-index of the toolbar, so we need to set the popup to be higher than that.

This is a follow-up from T281920#7174205.

Screen Shot 2021-06-23 at 6.26.39 PM.png (1×2 px, 1 MB)

Screen Shot 2021-06-23 at 9.24.04 PM.png (1×2 px, 1 MB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix onboarding popup behaviour and appearance	mediawiki/extensions/Wikisource	master	+42 -14

Customize query in gerrit

Related Objects

Mentioned In: T281920: Pulsating OCR onboarding UI
Mentioned Here: rEWSO847a252ee4a7: Merge "Fix onboarding popup behaviour and appearance"
T281920: Pulsating OCR onboarding UI

Event Timeline

Samwilson created this task.Jun 24 2021, 7:10 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptJun 24 2021, 7:10 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Samwilson mentioned this in T281920: Pulsating OCR onboarding UI.Jun 24 2021, 7:10 AM

Change 701472 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Wikisource@master] Fix onboarding popup behaviour and appearance

https://gerrit.wikimedia.org/r/701472

gerritbot added a project: Patch-For-Review.Jun 25 2021, 5:18 AM

Samwilson set the point value for this task to 2.Jun 25 2021, 5:25 AM

Samwilson edited projects, added Community-Tech (CommTech-Sprint-3); removed Community-Tech.

Samwilson moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-3) board.

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-4); removed Community-Tech (CommTech-Sprint-3).Jul 12 2021, 1:11 PM

ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-4) board.

Daimona moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-4) board.Jul 12 2021, 1:29 PM

@Samwilson I checked beta and I don't see the fix. Has this been pushed to beta? https://en.wikisource.beta.wmflabs.org/wiki/Index:Wind_in_the_Willows_(1913).djvu

No, it failed to merge because of a (seemingly unrelated) Selenium issue. I'll dig into it.

Change 701472 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] Fix onboarding popup behaviour and appearance

https://gerrit.wikimedia.org/r/701472

Maintenance_bot removed a project: Patch-For-Review.Jul 14 2021, 8:10 AM

Okay, it should be good on Beta now.

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 14 2021, 9:00 AM

Thanks @Samwilson. I was able to verify the issue is resolved in beta. Below are some screen shots
Test link:
https://en.wikisource.beta.wmflabs.org/wiki/Index:Wind_in_the_Willows_(1913).djvu

OCR Version tested:
Wikisource Version: – (847a252) 08:08, 14 July 2021 GPL-2.0-or-later

Screen Shot 2021-07-14 at 3.47.25 PM.png (1×2 px, 2 MB)

Screen Shot 2021-07-14 at 1.19.17 PM.png (1×2 px, 2 MB)

Screen Shot 2021-07-14 at 3.57.13 PM.png (1×2 px, 1 MB)

• imaigwilo moved this task from QA 🐛 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-4) board.Jul 15 2021, 2:55 AM

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-5); removed Community-Tech (CommTech-Sprint-4).Jul 19 2021, 1:35 PM

ldelench_wmf moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-5) board.

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-6); removed Community-Tech (CommTech-Sprint-5).Aug 2 2021, 6:06 PM

ldelench_wmf moved this task from Ready 🎬 to Product sign-off 🤘 on the Community-Tech (CommTech-Sprint-6) board.

• NRodriguez closed this task as Resolved.Aug 4 2021, 10:58 PM

ldelench_wmf moved this task from Product sign-off 🤘 to Done 🏁 on the Community-Tech (CommTech-Sprint-6) board.Aug 4 2021, 10:59 PM

	F34551466: Screen Shot 2021-07-14 at 1.19.17 PM.png
	Jul 14 2021, 11:33 PM

	F34551467: Screen Shot 2021-07-14 at 3.47.25 PM.png
	Jul 14 2021, 11:33 PM

	F34551465: Screen Shot 2021-07-14 at 3.57.13 PM.png
	Jul 14 2021, 11:33 PM

	F34524648: Screen Shot 2021-06-23 at 9.24.04 PM.png
	Jun 24 2021, 7:10 AM

	F34524646: Screen Shot 2021-06-23 at 6.26.39 PM.png
	Jun 24 2021, 7:10 AM

WikiEditor toolbar overlaps Wikisource onboarding popupClosed, ResolvedPublic2 Estimated Story PointsActions

Description

Details

Related Objects

Event Timeline

WikiEditor toolbar overlaps Wikisource onboarding popup
Closed, ResolvedPublic2 Estimated Story Points
Actions