Page MenuHomePhabricator

Hard-deprecate Parser::mUser public access, Parser::getUser and ParserOptions::getUser
Closed, ResolvedPublic

Description

These methods and property work together, so it makes sence to hard-deprecate them together. Standard hard deprecation: find all usages, fix usages, make a core hard-deprecation patch.

WMF deployed

  • extensions / Newsletter
  • extensions / WikimediaIncubator
  • services / parsoid
  • extensions / intersection
  • extensions / Math
  • extensions / SubPageList3
  • extensions / DiscussionTools

Event Timeline

Change 708532 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/core@master] Hard-deprecate Parser::mUser public access, Parser::getUser and ParserOptions::getUser

https://gerrit.wikimedia.org/r/708532

Change 712278 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/Cite@master] Adjust Parser related tests to DeprecationHelper

https://gerrit.wikimedia.org/r/712278

Change 712278 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Adjust Parser related tests to DeprecationHelper

https://gerrit.wikimedia.org/r/712278

Change 708532 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate Parser::mUser public access, Parser::getUser and ParserOptions::getUser

https://gerrit.wikimedia.org/r/708532

See T289625 -- deprecation was done although WMF-deployed code still uses it. Tried to fix, would appreciate a review.