Page MenuHomePhabricator
Create Task
Maniphest T285935

Disable EntityTypesDefinitionsFeddyPropsOverrider for entity type definitions
Closed, ResolvedPublic
Actions

Description

We still need to use this service in EntitySourceAndTypeDefinitions so we shouldn't delete it, but rename it so it shows that it's no longer overriding the functionality for local props.

Suggestion: EntityTypesConfigFeddyPropsAugmenter - also add a comment what the class does.

This should no longer be used in the service wiring for EntityTypeDefinitions.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
FP: Rename EntityTypeDefinitionsFeddyPropsOverridermediawiki/extensions/Wikibasemaster+14 -47
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Jul 1 2021, 11:14 AM
• Tonina_Zhelyazkova_WMDE updated the task description. (Show Details)
Rosalie_WMDE claimed this task.Jul 1 2021, 2:31 PM
Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.
gerritbot added a comment.Jul 2 2021, 10:37 AM

Change 702911 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] Rename EntityTypeDEfinitionsFeddyPropsOverrider to EntityTypesConfigFeddyPropsAugmenter

https://gerrit.wikimedia.org/r/702911

gerritbot added a project: Patch-For-Review.Jul 2 2021, 10:37 AM
Rosalie_WMDE mentioned this in T286060: Fix the testcase testFederatedPropertiesFailure which we currently skip.Jul 2 2021, 3:33 PM
Rosalie_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.Jul 2 2021, 4:02 PM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.Jul 6 2021, 3:12 PM
gerritbot added a comment.Jul 6 2021, 3:31 PM

Change 702911 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Rename EntityTypeDefinitionsFeddyPropsOverrider

https://gerrit.wikimedia.org/r/702911

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 6 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 6 2021, 4:10 PM
Addshore closed this task as Resolved.Jul 16 2021, 11:03 AM
Addshore closed subtask T286060: Fix the testcase testFederatedPropertiesFailure which we currently skip as Resolved.Aug 24 2021, 9:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits