Maniphest T285933

Services that need to become type and source dispatching aware
Closed, ResolvedPublic
Actions

Description

We need to at least swap out the lower level services assuming that the mid or higher level services are sufficiently source agnostic.

PrefetchingTermLookup (needed by LabelDescriptionLookup)
EntityExistanceChecker
EntityTitleTextLookup
EntityUrlLookup
EntityRedirectChecker

Details

	Subject	Repo	Branch	Lines +/-
	FP: Introduce ServiceBySourceAndTypeDispatcher	mediawiki/extensions/Wikibase	master	+169 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T285303 [EPIC] wbformatentities with both local and remote properties
		Resolved		Addshore	T285933 Services that need to become type and source dispatching aware
		Resolved		Rosalie_WMDE	T285935 Disable EntityTypesDefinitionsFeddyPropsOverrider for entity type definitions
		Resolved		Jakob_WMDE	T286060 Fix the testcase testFederatedPropertiesFailure which we currently skip
		Resolved		Jakob_WMDE	T286199 Create a source and type dispatching EntityUrlLookup
		Resolved		Jakob_WMDE	T286200 Create source and type dispatching PrefetchingTermLookup
		Resolved		• Tonina_Zhelyazkova_WMDE	T286201 Create a source and type dispatching EntityTitleTextLookup
		Resolved		Jakob_WMDE	T286202 Create a source and type dispatching EntityRedirectChecker
		Resolved		• Tonina_Zhelyazkova_WMDE	T286203 Make EntityExistenceChecker use ServiceBySourceAndTypeDispatcher
		Duplicate		None	T286205 Create Source And Type dispatching PrefetchingTermLookup

Event Timeline

• Tonina_Zhelyazkova_WMDE created this task.Jul 1 2021, 11:09 AM

Change 702674 had a related patch set uploaded (by Tarrow; author: Tarrow):

[mediawiki/extensions/Wikibase@master] FP: Introduce ServiceBySourceAndTypeDispatcher

https://gerrit.wikimedia.org/r/702674

gerritbot added a project: Patch-For-Review.Jul 1 2021, 2:44 PM

Rosalie_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.Jul 1 2021, 4:03 PM

Change 702907 had a related patch set uploaded (by Tonina Zhelyazkova; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Start using ServiceBySourceAndTypeDispatcher in TypeDispatchingExistenceChecker

https://gerrit.wikimedia.org/r/702907

Change 702674 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Introduce ServiceBySourceAndTypeDispatcher

https://gerrit.wikimedia.org/r/702674

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jul 2 2021, 3:00 PM

Tarrow updated the task description. (Show Details)Jul 5 2021, 10:47 AM

Rosalie_WMDE moved this task from Doing to To do on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.Jul 6 2021, 9:09 AM

• Tonina_Zhelyazkova_WMDE removed a project: Patch-For-Review.Jul 6 2021, 1:15 PM

Tarrow moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.Jul 7 2021, 9:08 AM

• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 2); removed Wikibase - Federated Properties (Federation v2 - Sprint 1).Jul 7 2021, 9:09 AM

• Samantha_Alipio_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.

• Tonina_Zhelyazkova_WMDE moved this task from Doing to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 2) board.Jul 14 2021, 11:05 AM

Addshore closed subtask T285935: Disable EntityTypesDefinitionsFeddyPropsOverrider for entity type definitions as Resolved.Jul 16 2021, 11:03 AM

Addshore closed this task as Resolved.Aug 24 2021, 9:34 AM

Addshore claimed this task.

Addshore closed subtask T286202: Create a source and type dispatching EntityRedirectChecker as Resolved.

Addshore closed subtask T286203: Make EntityExistenceChecker use ServiceBySourceAndTypeDispatcher as Resolved.

Addshore closed subtask T286201: Create a source and type dispatching EntityTitleTextLookup as Resolved.

Addshore closed subtask T286200: Create source and type dispatching PrefetchingTermLookup as Resolved.

Addshore closed subtask T286199: Create a source and type dispatching EntityUrlLookup as Resolved.

Restricted Application added a project: User-Addshore. · View Herald TranscriptAug 24 2021, 9:34 AM