Page MenuHomePhabricator

Article's more-menu border problem in vector2021
Open, Needs TriagePublic

Description

Let me show you in screens. Look at borders in "More" menu and other tab-links.

Legacy vector (borders on the right and left of tab-links):

obraz.png (1×1 px, 290 KB)

Current state of new-vector (no border on the left; border on the right):

obraz.png (1×1 px, 258 KB)

Fixed border in new vector (and some other stuff):

obraz.png (1×1 px, 313 KB)

So I assume you've intentionally removed left side border, but I think you simply forgot the right side. Hope that make sense.

CSS for removing the border (just for new vector):

@media screen {
    body:not(.skin-vector-legacy) #mw-head .vector-menu-dropdown h3 {
        background-image: none;
    }

PS: See also related reports for all other CSS: T286131, T286137

Event Timeline

Jdlrobson claimed this task.
Jdlrobson added a subscriber: Jdlrobson.

this doesn't look like a problem any more?

Screen Shot 2021-08-31 at 1.28.23 PM.png (506×2 px, 200 KB)

Please reopen if I've misunderstood.

The border seems to be still on your screen (marked it in red):

obraz.png (506×2 px, 138 KB)

Would expect not to have borders on both sides e.g. like so:

obraz.png (410×1 px, 56 KB)

Or maybe re-add border on the left.

@Nux thanks for raising this — I understand what you're referring to. It was discussed a little bit in T258277 as well.

I feel badly because this probably isn't a satisfactory answer, but the short answer is: we know this is an issue and we're going to be addressing it in the last phase of the project (the visual design phase). For example:

  • we might re-style the tabs
  • we might not present Article/Talk as tabs at all (there's a case to be made for not needing the "Article" tab when you're viewing the article, etc.)

@Jdlrobson @ovasileva if appropriate we could create a Visual refinement epic and attach this as a child task