Page MenuHomePhabricator
Create Task
Maniphest T286786

Error: Bad regular expression
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   Error: Bad regular expression
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Html2Wt/ConstrainedText/ConstrainedText.php(179)
#0 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Html2Wt/SerializerState.php(688): Wikimedia\Parsoid\Html2Wt\ConstrainedText\ConstrainedText->matches(string, Wikimedia\Parsoid\Config\Env)
#1 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(1198): Wikimedia\Parsoid\Html2Wt\SerializerState->emitChunk(Wikimedia\Parsoid\Html2Wt\ConstrainedText\ConstrainedText, DOMElement)
#2 [internal function]: Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOMNode(DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\PHandler)
#3 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(1332): call_user_func(array, DOMElement, Wikimedia\Parsoid\Html2Wt\DOMHandlers\PHandler)
#4 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Html2Wt/SerializerState.php(715): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeNode(DOMElement)
#5 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Html2Wt/SerializerState.php(741): Wikimedia\Parsoid\Html2Wt\SerializerState->serializeChildren(DOMElement, NULL)
#6 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Html2Wt/WikitextSerializer.php(1599): Wikimedia\Parsoid\Html2Wt\SerializerState->kickOffSerialize(DOMElement)
#7 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Html2Wt/SelectiveSerializer.php(236): Wikimedia\Parsoid\Html2Wt\WikitextSerializer->serializeDOM(DOMElement, boolean)
#8 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Core/WikitextContentModelHandler.php(168): Wikimedia\Parsoid\Html2Wt\SelectiveSerializer->serializeDOM(DOMDocument)
#9 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/src/Parsoid.php(280): Wikimedia\Parsoid\Core\WikitextContentModelHandler->fromDOM(Wikimedia\Parsoid\Config\Env, Wikimedia\Parsoid\Core\SelserData)
#10 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/extension/src/Rest/Handler/ParsoidHandler.php(827): Wikimedia\Parsoid\Parsoid->dom2wikitext(MWParsoid\Config\PageConfig, DOMDocument, array, Wikimedia\Parsoid\Core\SelserData)
#11 /srv/mediawiki/php-1.37.0-wmf.12/vendor/wikimedia/parsoid/extension/src/Rest/Handler/TransformHandler.php(133): MWParsoid\Rest\Handler\ParsoidHandler->html2wt(MWParsoid\Config\PageConfig, array, string)
#12 /srv/mediawiki/php-1.37.0-wmf.12/includes/Rest/Router.php(395): MWParsoid\Rest\Handler\TransformHandler->execute()
#13 /srv/mediawiki/php-1.37.0-wmf.12/includes/Rest/Router.php(322): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\TransformHandler)
#14 /srv/mediawiki/php-1.37.0-wmf.12/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#15 /srv/mediawiki/php-1.37.0-wmf.12/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#16 /srv/mediawiki/php-1.37.0-wmf.12/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#17 /srv/mediawiki/w/rest.php(3): require(string)
#18 {main}
Impact
Notes

Details

Request URL
https://nl.wikipedia.org/w/rest.php/nl.wikipedia.org/v3/transform/pagebundle/to/wikitext/Eredivisie_2021%2F22_(mannenvoetbal)/59412585
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.14.0-a10mediawiki/vendormaster+50 -52
Bump wikimedia/parsoid to 0.14.0-a9mediawiki/vendormaster+146 K -2 K
Fix backtracking in solRegexpmediawiki/services/parsoidmaster+11 -16
Bump wikimedia/parsoid to 0.14.0-a8mediawiki/vendormaster+132 -59
Strip the double underscores from the extension bswRegexpmediawiki/services/parsoidmaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

ssastry created this task.Jul 16 2021, 2:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2021, 2:12 PM
Arlolra subscribed.Jul 16 2021, 3:09 PM

We added some logging for this in T280449

https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-mediawiki-2021.07.13?id=S-v8oXoBCxLmWkI6RaEy

Arlolra added a comment.Jul 16 2021, 3:11 PM

preg_last_error: 2 corresponds to PREG_BACKTRACK_LIMIT_ERROR

ssastry added a comment.Jul 16 2021, 3:18 PM
In T286786#7217633, @Arlolra wrote:

We added some logging for this in T280449

https://logstash.wikimedia.org/app/discover#/doc/logstash-*/logstash-mediawiki-2021.07.13?id=S-v8oXoBCxLmWkI6RaEy

Huh .. looks like the whole page got pulled into the regexp or something unless i am misreading that log.

Arlolra added a comment.Jul 16 2021, 3:27 PM

$env->log( 'error', $error_msg, $re, $this->text );

ssastry added a comment.Jul 16 2021, 4:24 PM

Ah, ok.

Arlolra added a comment.Jul 16 2021, 6:52 PM

Tangential, but an interesting tidbit here is |__(?:(?i:__GEENINHOUD__|__NOTOC__|.... Doesn't look like that will ever match because of the outer __

The base regex uses synonyms (aliases) which include the double underscores,
https://github.com/wikimedia/mediawiki/blob/master/includes/MagicWordArray.php#L116

but we don't expect that,
https://github.com/wikimedia/parsoid/blob/master/src/Mocks/MockSiteConfig.php#L106-L113

Arlolra added a comment.Jul 16 2021, 7:02 PM

Looks like that was known in T232183#5507401

gerritbot added a comment.Jul 16 2021, 7:20 PM

Change 705012 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Strip the double underscores from the extension bswRegexp

https://gerrit.wikimedia.org/r/705012

gerritbot added a project: Patch-For-Review.Jul 16 2021, 7:20 PM
gerritbot added a comment.Jul 16 2021, 10:20 PM

Change 705012 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Strip the double underscores from the extension bswRegexp

https://gerrit.wikimedia.org/r/705012

gerritbot added a comment.Jul 16 2021, 10:50 PM

Change 705032 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Fix bad regular expression

https://gerrit.wikimedia.org/r/705032

Arlolra claimed this task.Jul 16 2021, 11:00 PM
Arlolra triaged this task as Medium priority.
Arlolra moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
gerritbot added a comment.Jul 19 2021, 8:24 PM

Change 705497 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a8

https://gerrit.wikimedia.org/r/705497

gerritbot added a comment.Jul 19 2021, 9:59 PM

Change 705497 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a8

https://gerrit.wikimedia.org/r/705497

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.15; 2021-07-19).Jul 19 2021, 10:00 PM
Krinkle moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.Jul 21 2021, 6:40 PM
gerritbot added a comment.Jul 22 2021, 7:40 PM

Change 705032 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Fix backtracking in solRegexp

https://gerrit.wikimedia.org/r/705032

Arlolra closed this task as Resolved.Jul 22 2021, 8:01 PM
gerritbot added a comment.Jul 26 2021, 4:28 PM

Change 708134 had a related patch set uploaded (by Subramanya Sastry; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a9

https://gerrit.wikimedia.org/r/708134

gerritbot added a comment.Jul 26 2021, 4:55 PM

Change 708134 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a9

https://gerrit.wikimedia.org/r/708134

gerritbot added a comment.Jul 26 2021, 10:35 PM

Change 708172 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a10

https://gerrit.wikimedia.org/r/708172

gerritbot added a comment.Jul 26 2021, 11:18 PM

Change 708172 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.14.0-a10

https://gerrit.wikimedia.org/r/708172

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits