Page MenuHomePhabricator
Create Task
Maniphest T287159

Move Content::prepareSave method that don't belong in Content to ContentHandler
Closed, ResolvedPublic
Actions

Description

These methods need to move to new corresponding methods in ContentHandler. Here's a patch that does the first part of the work for Content::preSaveTransform.

The signature of the ContentHandler method should be:

  • ContentHandler::prepareSave( Content, PageRecord, int, int, UserIdentity ) // TODO: discuss if PageRecord is needed or we can just do PageIdentity/Reference

The process:

Details

SubjectRepoBranchLines +/-
Hard-deprecate Content::prepareSave.mediawiki/coremaster+10 -4
Override ContentHandler::validateSave instead of Content::prepareSave.mediawiki/extensions/Wikibasemaster+52 -58
Override ContentHandler::validateSave instead of Content::prepareSave.mediawiki/extensions/Translatemaster+31 -11
Override ContentHandler::validateSave instead of Content::prepareSave.mediawiki/extensions/ProofreadPagemaster+204 -113
Override ContentHandler::validateSave instead of Content::prepareSave.mediawiki/extensions/Scribuntomaster+37 -19
Move Content::prepareSave to ContentHandlermediawiki/coremaster+180 -24
Override ContentHandler::validateSave instead of Content::prepareSave.mediawiki/extensions/TemplateStylesmaster+296 -254
Override ContentHandler::validateForRevision instead of Content::prepareSave.mediawiki/extensions/examplesmaster+38 -52
Customize query in gerrit

Related Objects
Search...

Event Timeline

roman-stolar created this task.Jul 22 2021, 2:05 PM
• Pchelolo moved this task from Unsorted pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.Jul 27 2021, 2:19 PM
daniel triaged this task as High priority.Aug 17 2021, 3:45 PM
roman-stolar moved this task from PageStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Oct 21 2021, 12:08 PM
gerritbot added a comment.Oct 22 2021, 12:48 PM

Change 732962 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Move Content::prepareSave to ContentHandler

https://gerrit.wikimedia.org/r/732962

gerritbot added a project: Patch-For-Review.Oct 22 2021, 12:48 PM
roman-stolar updated the task description. (Show Details)Oct 25 2021, 11:25 AM
roman-stolar updated the task description. (Show Details)
gerritbot added a comment.Oct 25 2021, 1:08 PM

Change 734261 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Wikibase@master] Override ContentHandler::confirmSave instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734261

roman-stolar updated the task description. (Show Details)Oct 25 2021, 1:08 PM
gerritbot added a comment.Oct 27 2021, 12:03 PM

Change 734949 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/ProofreadPage@master] Override ContentHandler::validateForRevision instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734949

roman-stolar updated the task description. (Show Details)Oct 27 2021, 12:03 PM
gerritbot added a comment.Oct 27 2021, 12:13 PM

Change 734950 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Scribunto@master] Override ContentHandler::validateForRevision instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734950

roman-stolar updated the task description. (Show Details)Oct 27 2021, 12:14 PM
gerritbot added a comment.Oct 27 2021, 12:45 PM

Change 734957 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/TemplateStyles@master] Override ContentHandler::validateForRevision instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734957

roman-stolar updated the task description. (Show Details)Oct 27 2021, 12:45 PM
gerritbot added a comment.Oct 27 2021, 1:00 PM

Change 734960 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/Translate@master] Override ContentHandler::validateForRevision instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734960

roman-stolar updated the task description. (Show Details)Oct 27 2021, 1:01 PM
gerritbot added a comment.Oct 28 2021, 2:35 PM

Change 735395 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/extensions/examples@master] Override ContentHandler::validateForRevision instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/735395

roman-stolar updated the task description. (Show Details)Oct 28 2021, 2:36 PM
roman-stolar updated the task description. (Show Details)Oct 28 2021, 3:03 PM
roman-stolar updated the task description. (Show Details)Oct 29 2021, 11:14 AM
roman-stolar updated the task description. (Show Details)Oct 29 2021, 12:14 PM
roman-stolar updated the task description. (Show Details)Nov 4 2021, 3:06 PM
roman-stolar updated the task description. (Show Details)Nov 4 2021, 5:34 PM
roman-stolar updated the task description. (Show Details)Nov 4 2021, 5:41 PM
roman-stolar updated the task description. (Show Details)Nov 5 2021, 12:27 PM
gerritbot added a comment.Nov 5 2021, 12:49 PM

Change 737030 had a related patch set uploaded (by Roman Stolar; author: Roman Stolar):

[mediawiki/core@master] Hard-deprecate Content::prepareSave.

https://gerrit.wikimedia.org/r/737030

roman-stolar updated the task description. (Show Details)Nov 5 2021, 12:49 PM
gerritbot added a comment.Nov 11 2021, 3:31 PM

Change 732962 merged by jenkins-bot:

[mediawiki/core@master] Move Content::prepareSave to ContentHandler

https://gerrit.wikimedia.org/r/732962

gerritbot added a comment.Nov 11 2021, 3:31 PM

Change 735395 merged by jenkins-bot:

[mediawiki/extensions/examples@master] Override ContentHandler::validateForRevision instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/735395

gerritbot added a comment.Nov 11 2021, 3:40 PM

Change 734957 merged by jenkins-bot:

[mediawiki/extensions/TemplateStyles@master] Override ContentHandler::validateSave instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734957

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 11 2021, 4:00 PM
gerritbot added a comment.Nov 11 2021, 4:01 PM

Change 734950 merged by jenkins-bot:

[mediawiki/extensions/Scribunto@master] Override ContentHandler::validateSave instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734950

roman-stolar mentioned this in rETSTcacfbe6a4f41: Override ContentHandler::validateSave instead of Content::prepareSave..Nov 11 2021, 4:04 PM
gerritbot added a comment.Nov 16 2021, 10:44 AM

Change 734949 merged by jenkins-bot:

[mediawiki/extensions/ProofreadPage@master] Override ContentHandler::validateSave instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734949

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 16 2021, 11:00 AM
gerritbot added a comment.Nov 19 2021, 2:34 PM

Change 734960 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Override ContentHandler::validateSave instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734960

gerritbot added a comment.Nov 23 2021, 11:20 AM

Change 734261 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Override ContentHandler::validateSave instead of Content::prepareSave.

https://gerrit.wikimedia.org/r/734261

gerritbot added a comment.Nov 23 2021, 11:20 AM

Change 737030 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate Content::prepareSave.

https://gerrit.wikimedia.org/r/737030

roman-stolar updated the task description. (Show Details)Nov 23 2021, 12:44 PM
roman-stolar updated the task description. (Show Details)
roman-stolar moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.
roman-stolar closed this task as Resolved.Dec 22 2021, 7:50 AM
Umherirrender mentioned this in T192777: Do not use Content::prepareSave when importing or undeleting (drop hard global constraints).Jan 14 2023, 10:24 PM
Aklapper updated the task description. (Show Details)Oct 9 2023, 1:26 PM
Aklapper removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL