Page MenuHomePhabricator
Create Task
Maniphest T287383

Increase contrast for line numbers (2017 wikitext editor)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Background

The line numbering in the 2017 wikitext editor does not have enough contrast to meet AA with the white background. This ticket darkens the color and increases the padding to the content so that they the two don't blend together, since they will look more similar.

See user feedback: https://meta.wikimedia.org/wiki/Talk:WMDE_Technical_Wishes/Line_Numbering#First_impressions

Requirements

  • Line numbering should be Base30 instead of Base 70
  • Padding should be 12px instead of 8px

Mock

2017 Wikitext editor-12px.png (616×777 px, 152 KB)
2017 Wikitext editor-specs updated.png (616×777 px, 154 KB)

Details

SubjectRepoBranchLines +/-
Improve text color & background in line numbers on VEmediawiki/extensions/CodeMirrormaster+3 -3
Customize query in gerrit

Event Timeline

JStrodt_WMDE created this task.Jul 26 2021, 2:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 26 2021, 2:46 PM
ECohen_WMDE moved this task from Backlog to In preparation on the WMDE-Templates-FocusArea board.Aug 25 2021, 9:01 AM
ECohen_WMDE updated the task description. (Show Details)Aug 25 2021, 9:08 AM
ECohen_WMDE moved this task from In preparation to Ready for story time on the WMDE-Templates-FocusArea board.
ECohen_WMDE renamed this task from Accessibility : Improve contrast for text color & background in line numbers to Improve contrast for text color & background in line numbers.Aug 25 2021, 10:27 AM
ECohen_WMDE added a project: Accessibility.
ECohen_WMDE updated the task description. (Show Details)
awight set the point value for this task to 2.Aug 25 2021, 1:12 PM
Lena_WMDE moved this task from Ready for story time to Ready for pickup on the WMDE-Templates-FocusArea board.Aug 25 2021, 1:27 PM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2021-09-01.Sep 1 2021, 8:20 AM
Lena_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Sep 1 2021, 8:22 AM
ECohen_WMDE removed ECohen_WMDE as the assignee of this task.Sep 1 2021, 8:43 AM
ECohen_WMDE subscribed.
WMDE-Fisch claimed this task.Sep 2 2021, 11:25 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-09-01 board.
gerritbot added a comment.Sep 2 2021, 11:54 AM

Change 716269 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/CodeMirror@master] Improve text color & background in line numbers on VE

https://gerrit.wikimedia.org/r/716269

gerritbot added a project: Patch-For-Review.Sep 2 2021, 11:54 AM
WMDE-Fisch moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 2 2021, 11:56 AM
ECohen_WMDE renamed this task from Improve contrast for text color & background in line numbers to Increase contrast for line numbers (2017 wikitext editor).Sep 2 2021, 11:56 AM
gerritbot added a comment.Sep 2 2021, 1:20 PM

Change 716269 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Improve text color & background in line numbers on VE

https://gerrit.wikimedia.org/r/716269

WMDE-Fisch moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 2 2021, 1:28 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 2 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 2 2021, 2:10 PM
lilients_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 14 2021, 8:13 AM
Lena_WMDE closed this task as Resolved.Sep 14 2021, 8:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits