The WikibaseLexeme extension adds some services to the MediaWiki container, in WikibaseLexeme.mediawiki-services.php, but also has its own service container, WikibaseLexemeServices. We should get rid of the latter and move all services into the MediaWiki service container.
Acceptance Criteria
Change 910475 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getTermLanguages()
Change 910476 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getLanguageNameLookupFactory()
Change 910477 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getEditFormChangeOpDeserializer()
Change 910478 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getGrammaticalFeaturesOrderProvider()
Change 910475 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getTermLanguages()
Change 910476 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getLanguageNameLookupFactory()
Change 910477 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getEditFormChangeOpDeserializer()
Change 910478 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getGrammaticalFeaturesOrderProvider()
(Note done yet, there are still a few custom services in WikibaseLexemeServices. The task isn’t done until we’ve completely removed its getSharedService() method.)
Prio Notes:
| Impact Area | Affected |
|---|---|
| production / end users | no |
| monitoring | no |
| development efforts | yes |
| onboarding efforts | yes |
| additional stakeholders | no |
newMergeLexemesInteractor() should be converted; getLexemeRepositoryFactory(), newLexemeMerger(), newNoCrossReferencingLexemeStatements(), getLexemeAuthorizer() and newLexemeRedirectorFactory() are all only used there (and only once), so arguably they could just be inlined into the MergeLexemesInteractor service wiring. Either way, they shouldn’t be in WikibaseLexemeServices anymore.
Change 991030 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getMergeLexemesInteractor()
Change 993733 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove LexemeAuthorizer, directly use EntityPermissionChecker
It seems that you've prepared a patch for this ticket while it's in the Prioritised backlog column. Do you mean for the ticket to be on our board? Should it now be in the Peer Review column?
In general, no, because I was just working on it during some spare time; I don’t think it should’ve been on the board for two weeks already. That said, it’s now close enough to the top of the unified backlog, and the patch is close enough to ready, that it makes sense to move it to our board now.
Should it now be in the Peer Review column?
No, because I’m still working on it.
Yes, now it is. (Forgot to move it there after adding it to the board, sorry.) But I don’t want to have something on our board for ages just because I occasionally work on it. By that measure, T312510 would’ve been on the board for a whole year.
Actually, it can go into review now, CI is finally green and I don’t have any TODOs either.
Change 993733 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove LexemeAuthorizer, directly use EntityPermissionChecker
Change 991030 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Standardize WikibaseLexemeServices::getMergeLexemesInteractor()
I think from my point of view that is exactly the point of the board - to see what you're working on. If you're working on a task for a year, it's on the board for a year, and then I have questions about why it's not broken into smaller pieces / made into an Epic. But at least everyone would have visibility that it's something that's eating up time and attention.
The patches address the issue, and they have been merged without any problems. Resolving this ticket.
Change 1002961 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@REL1_41] Remove LexemeAuthorizer, directly use EntityPermissionChecker
Change 1002961 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@REL1_41] Remove LexemeAuthorizer, directly use EntityPermissionChecker
Change 1002963 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@REL1_40] Remove LexemeAuthorizer, directly use EntityPermissionChecker
Change 1002963 merged by Lucas Werkmeister (WMDE):
[mediawiki/extensions/WikibaseLexeme@REL1_40] Remove LexemeAuthorizer, directly use EntityPermissionChecker
Change 1003479 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@REL1_39] Remove LexemeAuthorizer, directly use EntityPermissionChecker
Change 1003479 merged by Lucas Werkmeister (WMDE):
[mediawiki/extensions/WikibaseLexeme@REL1_39] Remove LexemeAuthorizer, directly use EntityPermissionChecker