Page MenuHomePhabricator

More menu items are too large in modern Vector skin
Closed, ResolvedPublicBUG REPORT

Description

Caused by: T287052

Right now the tab font size is not applied to menu items in the new Vector skin. I've split this from T288336 since that task was closed because vector is not responsible for supporting submenus added by gadgets and use scripts.

The tab font size is not applied to any menu items, causing menu item text to appear larger than the tab text.

image.png (143×210 px, 5 KB)

The issue is caused by T191021's commit, https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/702456/, which for some reason only applies the correct font size to span elements inside the links inside the menu items even though those span elements are never added by mw.util.addPortletLink.

Developer notes

We fixed this for legacy but not for modern. It may make sense to isolate some styles to the more menu itself in CSS.

Event Timeline

Jdlrobson renamed this task from Menu items are too large to More menu items are too large in modern skin.Aug 6 2021, 7:20 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.

This seems to be a regression relating to T287052

Jdlrobson renamed this task from More menu items are too large in modern skin to More menu items are too large in modern Vector skin.Aug 6 2021, 7:20 PM
Jdlrobson triaged this task as Medium priority.
ovasileva added a subscriber: ovasileva.

This is now fixed on the beta cluster

Screen Shot 2021-08-17 at 12.18.46 PM.png (1×2 px, 308 KB)
. Resolving.

The fix that was used on the beta cluster only applies to the tabs that are added by the skin, and not the ones added by user scripts using mw.util.addPortletLink.

image.png (151×180 px, 5 KB)

I've opened a new ticket for this one - T289163 - to avoid confusion as this relates to some different upstream code. Thanks for reporting @BrandonXLF

Jdlrobson claimed this task.