Page MenuHomePhabricator
Create Task
Maniphest T288367

More menu items are too large in modern Vector skin
Closed, ResolvedPublicBUG REPORT
Actions

Description

Caused by: T287052

Right now the tab font size is not applied to menu items in the new Vector skin. I've split this from T288336 since that task was closed because vector is not responsible for supporting submenus added by gadgets and use scripts.

The tab font size is not applied to any menu items, causing menu item text to appear larger than the tab text.

image.png (143×210 px, 5 KB)

The issue is caused by T191021's commit, https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/702456/, which for some reason only applies the correct font size to span elements inside the links inside the menu items even though those span elements are never added by mw.util.addPortletLink.

Developer notes

We fixed this for legacy but not for modern. It may make sense to isolate some styles to the more menu itself in CSS.

Related Objects

Event Timeline

BrandonXLF created this task.Aug 6 2021, 6:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 6 2021, 6:48 PM
BrandonXLF updated the task description. (Show Details)Aug 6 2021, 6:48 PM
BrandonXLF mentioned this in T288336: Tab font-size is not applied to menu item links.Aug 6 2021, 6:52 PM
Jdlrobson renamed this task from Menu items are too large to More menu items are too large in modern skin.Aug 6 2021, 7:20 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Web-Team-Backlog (Kanbanana-FY-2021-22), Regression.
Jdlrobson subscribed.

This seems to be a regression relating to T287052

Jdlrobson renamed this task from More menu items are too large in modern skin to More menu items are too large in modern Vector skin.Aug 6 2021, 7:20 PM
Jdlrobson triaged this task as Medium priority.
Nardog subscribed.Aug 6 2021, 10:36 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Aug 10 2021, 2:41 PM
Jdlrobson updated the task description. (Show Details)
ovasileva closed this task as Invalid.Aug 17 2021, 5:19 PM
ovasileva subscribed.

This is now fixed on the beta cluster

Screen Shot 2021-08-17 at 12.18.46 PM.png (1×2 px, 308 KB)
. Resolving.

BrandonXLF reopened this task as Open.Aug 17 2021, 7:37 PM

The fix that was used on the beta cluster only applies to the tabs that are added by the skin, and not the ones added by user scripts using mw.util.addPortletLink.

image.png (151×180 px, 5 KB)

Jdlrobson mentioned this in T289163: JavaScript addPortletLink method differs from PHP equivalent leading to gadget inconsistencies in modern Vector.Aug 18 2021, 3:10 PM

I've opened a new ticket for this one - T289163 - to avoid confusion as this relates to some different upstream code. Thanks for reporting @BrandonXLF

Jdlrobson closed this task as Resolved.Aug 18 2021, 3:29 PM
Jdlrobson claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL