Page MenuHomePhabricator
Create Task
Maniphest T288575

Pulsating UI to 1-click interaction on OCR
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

This is a follow-up from T285415.

Currently, when a user arrives on the proofread page, they see the pulsating dot for the new OCR feature.
When they click on the main OCR button, the popup opens, and once closed by clicking on "Okay, got it.", the user needs to click again to launch OCR.

Two changes could be made to optimize the experience and remove the need for a second click:

  1. Open popup when user clicks on either the OCR button or the dropdown arrow.
  2. When clicking 'Okay, got it', the onboarding popup should disappear and the action of whichever button they clicked will continue.

Details

SubjectRepoBranchLines +/-
Change onboarding popup click behaviourmediawiki/extensions/Wikisourcemaster+59 -6
Customize query in gerrit

Related Objects

Event Timeline

• NRodriguez created this task.Aug 10 2021, 8:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 10 2021, 8:26 PM
• NRodriguez added a project: Wikimedia OCR.Aug 10 2021, 8:26 PM
nayoub updated the task description. (Show Details)Aug 11 2021, 2:49 PM
Samwilson claimed this task.Aug 12 2021, 1:51 AM
Samwilson subscribed.

change the interaction to submit the OCR on the first click
Close the popup and start the OCR process when the user clicks on "Okay, got it."

Does that mean the OCR process should start when the button is clicked the first time, or when they click 'okay' in the popup?

Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-6) board.Aug 12 2021, 1:52 AM
• NRodriguez added a comment.Aug 12 2021, 1:24 PM

When they click "Okay, got it" from my understanding

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-7); removed Community-Tech (CommTech-Sprint-6).Aug 16 2021, 1:56 PM
ldelench_wmf moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-7) board.
Samwilson added a comment.Aug 18 2021, 5:41 AM

I've got this working, but I'm not totally sure what the best behaviour should be…

If we open the onboarding popup when clicking the options dropdown arrow, should both popups show (with the config one underneath the onboarding one)? If only the onboarding popup shows, should the options popup show after clicking 'Okay got it', or should the OCR run?

Samwilson updated the task description. (Show Details)Aug 19 2021, 1:31 AM
Samwilson set the point value for this task to 2.
gerritbot added a comment.Aug 20 2021, 8:10 AM

Change 714012 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/Wikisource@master] Change onboarding popup click behaviour

https://gerrit.wikimedia.org/r/714012

gerritbot added a project: Patch-For-Review.Aug 20 2021, 8:10 AM
Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-7) board.Aug 26 2021, 5:31 AM

This is ready for review now.

ldelench_wmf edited projects, added Community-Tech (CommTech-Sprint-8); removed Community-Tech (CommTech-Sprint-7).Aug 30 2021, 8:40 PM
ldelench_wmf moved this task from Ready 🎬 to Review/Feedback 💬 on the Community-Tech (CommTech-Sprint-8) board.
gerritbot added a comment.Aug 31 2021, 9:59 PM

Change 714012 merged by jenkins-bot:

[mediawiki/extensions/Wikisource@master] Change onboarding popup click behaviour

https://gerrit.wikimedia.org/r/714012

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Aug 31 2021, 10:00 PM
MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Sprint-8) board.Aug 31 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 31 2021, 10:10 PM
• imaigwilo subscribed.EditedSep 9 2021, 3:54 PM

Looks good in Beta, the feature works per description. Below is a screen shot of this scenario: open popup when user clicks on either the OCR button or the dropdown arrow.
Beta url: https://en.wikisource.beta.wmflabs.org/w/index.php?title=Page:Dictionary_of_National_Biography_volume_51.djvu/67&action=edit&redlink=1

Screen Shot 2021-09-09 at 11.46.37 AM.png (1×2 px, 1 MB)

Also did browser comparability testing on Chrome, Safari, and Firefox, and Edge

• imaigwilo moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Sprint-8) board.Sep 9 2021, 5:27 PM
ldelench_wmf closed this task as Resolved.Sep 13 2021, 7:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL