Bug: VE template dialog trash can should not disappear for required params
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

None

Authored By

	awight
	Aug 17 2021, 8:34 AM

Description

We've introduced new behavior, to make the sidebar toolbar trash can disabled for template parameters. But for required parameters, the trash can disabled entirely. When the new sidebar feature flag is enabled, do not hide the trash can.

Details

	Subject	Repo	Branch	Lines +/-
	Utilize native .isRemovable() in template dialog sidebar	mediawiki/extensions/VisualEditor	master	+5 -7

Customize query in gerrit

Event Timeline

awight created this task.Aug 17 2021, 8:34 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2021, 8:34 AM

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Aug 17 2021, 4:43 PM

Check whether this is still a problem.

Lena_WMDE moved this task from Backlog to Ready for pickup on the WMDE-Templates-FocusArea board.Sep 1 2021, 8:25 AM

awight added a project: WMDE-TechWish-Sprint-2021-09-01.Sep 13 2021, 11:52 AM

Change 720769 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Utilize native .isRemovable() in template dialog sidebar

https://gerrit.wikimedia.org/r/720769

gerritbot added a project: Patch-For-Review.Sep 14 2021, 7:58 AM

I accidentally fixed this without knowing this ticket exists, see https://gerrit.wikimedia.org/r/720769.

lilients_WMDE moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-09-01 board.Sep 15 2021, 7:51 AM

thiemowmde added a project: WMDE-TechWish-Sprint-2021-09-15.Sep 15 2021, 8:12 AM

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-09-15 board.

Lena_WMDE moved this task from Ready for pickup to In sprint on the WMDE-Templates-FocusArea board.Sep 15 2021, 8:17 AM

Change 720769 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Utilize native .isRemovable() in template dialog sidebar

https://gerrit.wikimedia.org/r/720769

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 16 2021, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2021, 10:10 AM

awight moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-09-15 board.Sep 20 2021, 10:04 AM

ECohen_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-09-15 board.Sep 28 2021, 8:20 AM

thiemowmde closed this task as Resolved.Sep 28 2021, 8:29 AM

Bug: VE template dialog trash can should not disappear for required paramsClosed, ResolvedPublic1 Estimated Story PointsActions

Description

Details

Event Timeline

Bug: VE template dialog trash can should not disappear for required params
Closed, ResolvedPublic1 Estimated Story Points
Actions