Page MenuHomePhabricator
Create Task
Maniphest T289176

WaitConditionLoop should fail when condition is aborted
Closed, ResolvedPublicBUG REPORT
Actions

Description

In T288233#7286917, @EBernhardson wrote:

WaitConditionLoop has a bug, repro:

>>> (new Wikimedia\WaitConditionLoop(function () { 
       return Wikimedia\WaitConditionLoop::CONDITION_ABORTED; 
    }, 0))->invoke() === Wikimedia\WaitConditionLoop::CONDITION_REACHED
=> true

In wmf.14 this bug allowed the MessageCache to fail, but continue anyways. The MessageCache would disable itself and fallback to LocalisationCache which reads from CDB files.

In wmf.15 the intermediary lock/unlock in BagOStuff was refactored. This refactor avoided the bug above by following a slightly different path to deciding if the lock was actually locked. With the lock correctly reporting failure in wmf.15 the [CirrusSearch] maintenance scripts are no longer running.

Details

SubjectRepoBranchLines +/-
Update wikimedia/wait-condition-loop from 2.0.1 to 2.0.2mediawiki/coremaster+2 -1
Update wikimedia/wait-condition-loop from 2.0.1 to 2.0.2mediawiki/vendormaster+43 -21
Tag 2.0.2mediawiki/libs/WaitConditionLoopmaster+4 -0
Correctly report failure with no timeoutmediawiki/libs/WaitConditionLoopmaster+13 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.Aug 18 2021, 4:41 PM
Restricted Application added a project: Performance-Team. · View Herald TranscriptAug 18 2021, 4:41 PM
gerritbot added a comment.Aug 18 2021, 4:41 PM

Change 713337 had a related patch set uploaded (by Krinkle; author: Ebernhardson):

[mediawiki/libs/WaitConditionLoop@master] Correctly report failure with no timeout

https://gerrit.wikimedia.org/r/713337

gerritbot added a project: Patch-For-Review.Aug 18 2021, 4:41 PM
Krinkle assigned this task to aaron.Aug 18 2021, 4:41 PM
Krinkle triaged this task as Medium priority.
Krinkle moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.
gerritbot added a comment.Aug 20 2021, 9:12 PM

Change 713337 merged by jenkins-bot:

[mediawiki/libs/WaitConditionLoop@master] Correctly report failure with no timeout

https://gerrit.wikimedia.org/r/713337

Krinkle mentioned this in R1981:f7f400ce7ddc: Correctly report failure with no timeout.Aug 20 2021, 9:13 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 20 2021, 10:10 PM
Krinkle claimed this task.Aug 23 2021, 6:51 PM

I'll tag a release and submit the pull throughs for core vendor.

Krinkle mentioned this in T287972: Make new releases of all Wikimedia-authored PHP libraries, and bump their usages (mid-2021).Aug 23 2021, 7:01 PM
gerritbot added a comment.Aug 23 2021, 7:39 PM

Change 714408 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/libs/WaitConditionLoop@master] Tag 2.0.2

https://gerrit.wikimedia.org/r/714408

gerritbot added a project: Patch-For-Review.Aug 23 2021, 7:39 PM
gerritbot added a comment.Aug 23 2021, 8:14 PM

Change 714408 merged by jenkins-bot:

[mediawiki/libs/WaitConditionLoop@master] Tag 2.0.2

https://gerrit.wikimedia.org/r/714408

Krinkle mentioned this in R1981:9bb0894e8c51: Tag 2.0.2.Aug 23 2021, 8:37 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 23 2021, 9:11 PM
gerritbot added a comment.Aug 23 2021, 9:25 PM

Change 714419 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update wikimedia/wait-condition-loop from 2.0.1 to 2.0.2

https://gerrit.wikimedia.org/r/714419

gerritbot added a project: Patch-For-Review.Aug 23 2021, 9:25 PM
gerritbot added a comment.Aug 23 2021, 10:24 PM

Change 714429 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/vendor@master] Update wikimedia/wait-condition-loop from 2.0.1 to 2.0.2

https://gerrit.wikimedia.org/r/714429

gerritbot added a comment.Aug 24 2021, 4:37 PM

Change 714429 merged by jenkins-bot:

[mediawiki/vendor@master] Update wikimedia/wait-condition-loop from 2.0.1 to 2.0.2

https://gerrit.wikimedia.org/r/714429

gerritbot added a comment.Aug 24 2021, 4:41 PM

Change 714419 merged by jenkins-bot:

[mediawiki/core@master] Update wikimedia/wait-condition-loop from 2.0.1 to 2.0.2

https://gerrit.wikimedia.org/r/714419

Krinkle closed this task as Resolved.Aug 24 2021, 5:39 PM
Krinkle reassigned this task from Krinkle to EBernhardson.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits