Page MenuHomePhabricator

Edge Caches can lead to broken Query Builder for some time after deploy
Closed, ResolvedPublicBUG REPORT

Description

If someone requests https://query.wikidata.org/querybuilder/ and 10 minutes later https://query.wikidata.org/querybuilder/?lang=fa is requested, then the Edge Cache's Time To Live (TTL) for the asset files (js, css) referenced by both will expire 10 minutes earlier than the TTL for https://query.wikidata.org/querybuilder/?lang=fa that references those files. If within the TTL for https://query.wikidata.org/querybuilder/?lang=fa a new release is deployed, then it will be broken for the time from when the asset TTL expired until itself expires and is replaced with the current version that references the correct assets.

Worst case, this could mean some query builder links being broken for up to an hour after deployment.

Event Timeline

GUI itself had this issue when we were deploying new version as well.

Change 799297 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/puppet@production] query_service: don’t cache index files

https://gerrit.wikimedia.org/r/799297

Change 799297 merged by RLazarus:

[operations/puppet@production] query_service: don’t cache index files

https://gerrit.wikimedia.org/r/799297

Change 807200 had a related patch set uploaded (by Ryan Kemper; author: Ryan Kemper):

[operations/puppet@production] query_service: fix syntax error

https://gerrit.wikimedia.org/r/807200

Change 807200 merged by Ryan Kemper:

[operations/puppet@production] query_service: fix syntax error in apache config

https://gerrit.wikimedia.org/r/807200

Lucas_Werkmeister_WMDE claimed this task.

Seems to be fixed now, I didn’t notice any query builder errors after today’s deployment.